audio.h: fix error ISO C restricts enumerator values to range of 'int' #2693
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error
~/dsp/libs/tinyusb/src/class/audio/audio.h:643:53: error: ISO C restricts enumerator values to range of 'int' before C23 [-Werror=pedantic]
643 | AUDIO_CHANNEL_CONFIG_RAW_DATA = 0x80000000, // TODO
| ^~~~~~~~~~
compilation terminated due to -Wfatal-errors.
Closes: hathach#2690
HiFiPhile
approved these changes
Jun 28, 2024
|
thank you. Have a nice weekend! |
|
will need to revert this since this cause, note that int is not guaranteed to be 32bit for all platform. Not sure why build workflow does not trigger for this PR. |
|
Good spot, don't know how I overlooked this even I work alot on STM8 who has 16 bit int... |
|
using |
it is still overflowed since first bit is considered signed bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
fix error
Closes: #2690