fix(usbh): robustness against unplugging usb device when it is busy #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
As @hathach said, it is hacky, not a clean way. However, for me, it works perfectly. The pitful will be if the port is supporting a hub or if the rp2040 usb supports two ports as well that you are using as a host. In a single port full speed host for mass storage, this hack will work like a charm 👌, please let me know if it works for you |
|
@abakosh It seems it's working great in my case. I came across this today and came to almost the same solution as you. As far as I understand, the RP2040 has one port, so everything should be fine. |
|
Potentiall addressed by the behaviour cahnge in #2550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Host Library:
The unplugging process of the USB device might lead to an infinite loop. It is easy to run into this situation if unplugging occurs during the enumeration process. Also, it happens when unplugging while the host and the USB device are doing something.
The issue is really big. As the stack enters an infinite loop when this is happening.
Additional context
I am testing with the RA4M2 family, with no OS. I know this fix is not meant if you are hosting a hub device. However, if you are planning to host a single device, it increases the robustness of plugging/unplugging while busy issue.
This was tested with MSC devices, I can see the improvement.
@hathach I am not sure if this fix is contagious for other scenarios. Please let me know if I need to take care of something else.
Thank you.