Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For FreeRTOS kernel-aware debugging, when queue registry is enabled, … #2091

Merged
merged 8 commits into from
Aug 3, 2023

Conversation

DRNadler
Copy link
Contributor

@DRNadler DRNadler commented Jun 1, 2023

Help with debugging by labeling the tinyUSB event queue.
Makes the queue visible to task-aware debug windows FreeRTOS tasks and FreeRTOS queues.
Helps with debugging under FreeRTOS!
Note: generates no code if developer has not enabled queue registry debug tool.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, though tinyusb has seperate queue for device and host, we should take that into consideration as well. "usbd"/"usbh" string should be added to OSAL_QUEUE_DEF() as queue name. Would you mind making the change, no worries if you don't have time, I could make change myself later when possible

@DRNadler
Copy link
Contributor Author

@hathach - I added queue name to OSAL_QUEUE_DEF() as you suggested and clarified queue names to make debug easier. Hope its OK!

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your PR and patient. Changing qdef name is actually not what I mean. Although the name is a bit odd _usbd_qdef. It is still useful since user would know which variable to look at, let just keep that. I also update to only include the name if needed and does quite a bit of reformat. Will merge will ci is complete

@hathach hathach merged commit e5b1718 into hathach:master Aug 3, 2023
82 of 83 checks passed
@DRNadler
Copy link
Contributor Author

DRNadler commented Aug 3, 2023

Although the name is a bit odd _usbd_qdef...

Clear variable names and comments ease development, debug, and maintenance,
and are the mark of a great programmer ;-) ;-)

Thanks @hathach !!
Best Regards, Dave

@hathach
Copy link
Owner

hathach commented Aug 4, 2023

I am never good with naming :(

@DRNadler
Copy link
Contributor Author

DRNadler commented Aug 4, 2023

Seriously @hathach:
Steve McConnell "Code Complete" (first edition, not 2nd).

Chapter 9 "The Power of Data Names"
Naming data checklist, page 212-213.
I found it extremely helpful!
A really excellent book on programming (and there aren't that many)...
https://www.amazon.com/Complete-Microsoft-Programming-Steve-McConnell/dp/1556154844
Best Regards, Dave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants