-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For FreeRTOS kernel-aware debugging, when queue registry is enabled, … #2091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, though tinyusb has seperate queue for device and host, we should take that into consideration as well. "usbd"/"usbh" string should be added to OSAL_QUEUE_DEF() as queue name. Would you mind making the change, no worries if you don't have time, I could make change myself later when possible
@hathach - I added queue name to OSAL_QUEUE_DEF() as you suggested and clarified queue names to make debug easier. Hope its OK! |
…e-aware debuggers" This reverts commit 11fba59.
also mass change configQUEUE_REGISTRY_SIZE = 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your PR and patient. Changing qdef name is actually not what I mean. Although the name is a bit odd _usbd_qdef. It is still useful since user would know which variable to look at, let just keep that. I also update to only include the name if needed and does quite a bit of reformat. Will merge will ci is complete
Although the name is a bit odd Clear variable names and comments ease development, debug, and maintenance, Thanks @hathach !! |
I am never good with naming :( |
Seriously @hathach: Chapter 9 "The Power of Data Names" |
Help with debugging by labeling the tinyUSB event queue.
Makes the queue visible to task-aware debug windows FreeRTOS tasks and FreeRTOS queues.
Helps with debugging under FreeRTOS!
Note: generates no code if developer has not enabled queue registry debug tool.