audio.h: error: ISO C restricts enumerator values to range of 'int' before C23 [-Werror=pedantic]

[ra1nb0w]

Operating System

Linux

Board

STM32H563 Nucleo

Firmware

custom

What happened ?

These lines issue a warning/error when strictly following the ISO C standard before 23

tinyusb/src/class/audio/audio.h

Line 492 in 756ad35

AUDIO_DATA_FORMAT_TYPE_I_RAW_DATA = 0x80000000,

tinyusb/src/class/audio/audio.h

Line 643 in 756ad35

AUDIO_CHANNEL_CONFIG_RAW_DATA = 0x80000000,

How to reproduce ?

built with gcc -Wfatal-errors -Wall -Wextra -Wpedantic -std=c11

For more insight see https://stackoverflow.com/questions/11314545/casting-enum-definition-to-unsigned-int

Debug Log as txt file (LOG/CFG_TUSB_DEBUG=2)

~/dsp/libs/tinyusb/src/class/audio/audio.h:643:53: error: ISO C restricts enumerator values to range of 'int' before C23 [-Werror=pedantic]
  643 |   AUDIO_CHANNEL_CONFIG_RAW_DATA                   = 0x80000000, // TODO
      |                                                     ^~~~~~~~~~
compilation terminated due to -Wfatal-errors.

Screenshots

No response

I have checked existing issues, dicussion and documentation

• I confirm I have checked existing issues, dicussion and documentation.

[HiFiPhile]

I read the post ,does it work with (int)(1U << 31U) ?

[ra1nb0w]

works fine. Also tested with

/**
 * build with
 * gcc -Wfatal-errors -Wall -Wextra -Wpedantic -std=c11
 */

#include <stdio.h>
#include <stdint.h>

#define BYTE_TO_BINARY_PATTERN "%c%c%c%c%c%c%c%c"
#define BYTE_TO_BINARY(byte)  \
  ((byte) & 0x80 ? '1' : '0'), \
  ((byte) & 0x40 ? '1' : '0'), \
  ((byte) & 0x20 ? '1' : '0'), \
  ((byte) & 0x10 ? '1' : '0'), \
  ((byte) & 0x08 ? '1' : '0'), \
  ((byte) & 0x04 ? '1' : '0'), \
  ((byte) & 0x02 ? '1' : '0'), \
  ((byte) & 0x01 ? '1' : '0') 

typedef enum
{
  A = (int)(1U << 31U),
} size_test;

int main(void)
{
  printf(BYTE_TO_BINARY_PATTERN " " BYTE_TO_BINARY_PATTERN " " BYTE_TO_BINARY_PATTERN " " BYTE_TO_BINARY_PATTERN "\n",
         BYTE_TO_BINARY(A >> 24), BYTE_TO_BINARY(A >> 16), BYTE_TO_BINARY(A >> 8), BYTE_TO_BINARY(A)
  );
}

Do you need a PR or do the change yourself?
Anyway, thank you very much for all your work!

[HiFiPhile]

Please make a PR so I can approve it sooner.

[ra1nb0w]

maybe we should re-open this until we find a solution

[yueduz]

"1u << 30u" will fix it

[HiFiPhile]

"1u << 30u" will fix it

That's 0x40000000 not 0x80000000 !

[yueduz]

I thought we didn't need such large enum values. If that's how the uac standard defines it, then we can only use #define.

[yueduz]

"1u << 30u" will fix it

That's 0x40000000 not 0x80000000 !

The "int" two's complement of "-2147483648" will be 0x80000000 for "uint"

I get a compiler warning, but I think it's safe to replace.