Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subnet protection for non-full network states (eg. limited, etc.) #419

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix subnet protection for non-full network states (eg. limited, etc.) #419

wants to merge 3 commits into from

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Oct 22, 2024

Proposed Changes

  • Subnet protection was down when the connection wasn't FULL, ie. even a LIMITED (eg. WAN outage) was able to turn off the protection.
  • With this fix, protection is reapplied (unprotect then protect immediately) on interface down, up, dhcp4-change, chcp6-change events.
  • Better do it more often then less. These events happen quite rarely, so it shouldn't be a performance issue.
  • Additionally it waits for the supervisor to be up for 5 minutes (instead of 1,5 minutes). It's usefull when the supervisor is restarted.
  • Plus some minor refactoring, bugfixes.

Related Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lmagyar