Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GHC-63394 (messages from WARNING and DEPRECATED pragmas) #481

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Lysxia
Copy link
Contributor

@Lysxia Lysxia commented Mar 14, 2024

No description provided.

Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good.
Just one fix to make the link work correctly

`{-# DEPRECATED ... #-}`.
For more information, [see the GHC user's guide][users-guide].

[users-guide]: https://downloads.haskell.org/ghc/latest/docs/users_guide/exts/pragmas.html#warning-and-deprecated-pragmas)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[users-guide]: https://downloads.haskell.org/ghc/latest/docs/users_guide/exts/pragmas.html#warning-and-deprecated-pragmas)
[users-guide]: https://downloads.haskell.org/ghc/latest/docs/users_guide/exts/pragmas.html#warning-and-deprecated-pragmas

@jhrcek
Copy link
Collaborator

jhrcek commented Mar 15, 2024

Hello @BinderDavid
do you want to take a look or are you in general ok if I merge "content addition" PRs if I find them ok?

@BinderDavid
Copy link
Collaborator

Hello @BinderDavid
do you want to take a look or are you in general ok if I merge "content addition" PRs if I find them ok?

In cases such as this where the problem and the solution of the error are relatively straightforward you can merge them directly. But in more complicated cases it is always good to have more than one pair of eyes which take a look :)

@jhrcek jhrcek merged commit d6a7d82 into haskellfoundation:main Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants