Draft: Migrate `hls-class-plugin` to use structured diagnostics#4472

Draft

fendor wants to merge 74 commits intohaskell:masterfrom fendor:enhance/hls-class-plugin/structured

+1,137-435

Commits on Oct 23, 2024

Change FileDiagnostic type synonym to a datatype

dylan-thinnes
authored and
noughtmare
committed
Make ideErrorWithSource produce FileDiagnostic by adding filepath arg

dylan-thinnes
authored and
noughtmare
committed
Supply structured error wherever we easily can - TODOs for hard parts

dylan-thinnes
authored and
noughtmare
committed
Fix UnitTests for new FileDiagnostic struct

dylan-thinnes
authored and
noughtmare
committed
Remove explicit uses of FileDiagnostic, add codes to LSP diagnostics

dylan-thinnes
authored and
noughtmare
committed
Add field for expected error codes in ghcide tests

dylan-thinnes
authored and
noughtmare
committed
Expect GHC-83865 for "type error" test - basic test

dylan-thinnes
authored and
noughtmare
committed
Return structured warnings in TcModuleResult by copying from Driver

dylan-thinnes
authored and
noughtmare
committed
Store FileDiagnostic instead of LSP Diagnostic in Shake store

dylan-thinnes
authored and
noughtmare
committed
Add expected error codes for diagnostics that have them

dylan-thinnes
authored and
noughtmare
committed
Dispatch TODOs, amend remaining TODOs as future work

dylan-thinnes
authored and
noughtmare
committed
Add scary comments all over copied code in Compat.Driver

dylan-thinnes
authored and
noughtmare
committed
Update all remaining diagnostics that could use an expected error code

dylan-thinnes
authored and
noughtmare
committed
Add _code to pretty printing for FileDiagnostic

dylan-thinnes
authored and
noughtmare
committed
Use case instead of maybe for StructuredMessage match

dylan-thinnes
authored and
noughtmare
committed
Use CPP to prevent setting _code before structured errors

dylan-thinnes
authored and
noughtmare
committed
Swap modifier for lenses, document StructuredMessage type

dylan-thinnes
authored and
noughtmare
committed
Add link to Issue & MR to Compat.Driver

dylan-thinnes
authored and
noughtmare
committed
Drop attachReason logic from withWarnings, technically incorrect

dylan-thinnes
authored and
noughtmare
committed
Revert "Drop attachReason logic", needed by pragmas-plugin

dylan-thinnes
authored and
noughtmare
committed
Fix plugins where necessary for new diagnostic structure

dylan-thinnes
authored and
noughtmare
committed
Fix build issues with other tests from expectDiagnostics

dylan-thinnes
authored and
noughtmare
committed
Improve comment on metadata fdStructuredMessage in FileDiagnostic

dylan-thinnes
authored and
noughtmare
committed
Add note to withWarnings explaining the current state of things

dylan-thinnes
authored and
noughtmare
committed
Attach reasons into data field of LSP Diagnostic instead of code field

dylan-thinnes
authored and
noughtmare
committed
Fix up mistakes from merge, TODO fix merge issues for 9.3.0

dylan-thinnes
authored and
noughtmare
committed
Set CodeDescription from HaskellErrorIndex when available

dylan-thinnes
authored and
noughtmare
committed
Remove debugging print, fix expectation for preprocessor tests

dylan-thinnes
authored and
noughtmare
committed
Fix CPP for using Show instance on DiagnosticCode

dylan-thinnes
authored and
noughtmare
committed
Remove diagFromErrMsgs for GHC version < 9.6.1 using CPP

dylan-thinnes
authored and
noughtmare
committed
CPP fix

dylan-thinnes
authored and
noughtmare
committed
More stylish-haskell, more CPP fix

dylan-thinnes
authored and
noughtmare
committed
Fix all stylish-haskell errors triggering

dylan-thinnes
authored and
noughtmare
committed
Fix more CPP

dylan-thinnes
authored and
noughtmare
committed
Only override the LSP diagnostic code when not already set

dylan-thinnes
authored and
noughtmare
committed
Fixes for stylish-haskell

dylan-thinnes
authored and
noughtmare
committed
Qualify s, t for FuzzySearch

dylan-thinnes
authored and
noughtmare
committed
Ignore use of unsafePerformIO in FuzzySearch

dylan-thinnes
authored and
noughtmare
committed
Properly split GHC.Types.Error import in Diagnostics for stylish-haskell

dylan-thinnes
authored and
noughtmare
committed
Force type signature of annotation on FuzzySearch.dictionary

dylan-thinnes
authored and
noughtmare
committed
DRY up definition of closure_errs

dylan-thinnes
authored and
noughtmare
committed
Remove unused imports
noughtmare
committed
Post-rebase fixes
noughtmare
committed
stylish-haskell formatting
noughtmare
committed
Fix issue with GHC 9.4
noughtmare
committed
Please stylish-haskell
noughtmare
committed
Ignore error codes when testing GHC 9.4
noughtmare
committed
Workaround darwin GHC bug in hls-hlint-plugin
noughtmare
committed
Put the workaround in the right place
noughtmare
committed

Commits on Oct 25, 2024

Commits on Oct 26, 2024

Remove unused imports
noughtmare
committed

Commits on Oct 28, 2024

Remove StructuredDiagnostic
noughtmare
committed

Commits on Nov 21, 2024

Commits on Dec 23, 2024