-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up logo #4442
base: master
Are you sure you want to change the base?
Clean up logo #4442
Conversation
Better alignment and more consistent spacing.
Thanks for the PR! |
If we decide to change the logo: I suggest to change L and S to provide more support for the lambda, so that the logo can express that this Language Server (what L and S stand for) provides a stable base for Haskell (what the Haskell logo stands for) development. |
Huh, that is interesting about the Google logo. I'd never noticed that. Still, I feel strongly that making the angles consistent with the Haskell logo and straightening up the perimeter are clear improvements (leaving the widths of the letters and the heights of the lines within them as the potentially controversial parts). Do you not agree? I'm not certain I know what you mean by "the lambda suppressed L and S" and "change L and S to provide more support for the lambda", without seeing rough sketches, but I'm also reluctant to waste anyone's time bikeshedding this too much... |
@georgefst By that, basically I mean making the top part of L and S wider enough than the bottom part of lambda. One possibility is that I over-widened the top part to a visually unpleasing level, but I still believe the linearly matching width is not wide enough to visually support the lambda character stably. |
Oh, I think I see. Your issue is that the bottom-left corner of the lambda is not "supported", in the sense that there's nothing underneath it? I think that could only be rectified by dropping the arrow from the logo, i.e. the darker purple part on the left. Then again, that could be cool, because it would bring us down to three glyphs, so we could use one colour for each. I might play around with this, although it's a more radical change than I intended... EDIT: Re-reading the above comment again, I see I may have missed your point and gotten carried away with my own idea. Anyway, I don't think I agree on the importance of seeing the image as a physical model. |
@georgefst Not really about the floating leg of lambda. Maybe I should have used "Haskell logo" instead of "lambda character" in the above description. I don't think it as a physical model (if I did, then I would be against that floating leg). It is more about that there is some visual intuition that affects people's view. When something is smaller, people could think that is less important. Likewise, if something is on a tight base, it seems unstable. If that tight base stands for something, then that something gives an impression of a weak foundation. I think this goes against the actual impression we want to give. We want to say (or at the very least I wanted to say) that HLS is a concrete basis of development on Haskell codebases. |
I might be the only person who really cares about this, but every time I've seen this logo in the last four years the fact that nothing is aligned properly has irritated me.
I can match the gaps and thicknesses of the old version more closely if people genuinely prefer it, but I've taken the measurements from the actual Haskell logo instead.