Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ghcide-bench by default #4376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Aug 7, 2024

Introduce a cabal flag to control the building of ghcide-bench, which is an internal tool for benchmarking HLS.

This fixes a regression, where running cabal install haskell-language-server to install HLS from Hackage would install ghcide-bench as well as the required HLS executables.

Fixes #4359

POC, so we can iterate on this.

Introduce a cabal flag to control the building of `ghcide-bench`,
which is an internal tool for benchmarking HLS.

This fixes a regression, where running
`cabal install haskell-language-server` would install `ghcide-bench` as
well as the required HLS executables.
@soulomoon
Copy link
Collaborator

Do we need to update the github CI as well ?

@fendor
Copy link
Collaborator Author

fendor commented Aug 7, 2024

Yeah probably, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is ghcide-bench supposed to be built and installed by default?
2 participants