Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch ghcide tests to sequential execution #4307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch ghcide tests to sequential execution #4307

wants to merge 1 commit into from

Conversation

dyniec
Copy link
Contributor

@dyniec dyniec commented Jun 9, 2024

Should address #3245

@dyniec dyniec requested a review from wz1000 as a code owner June 9, 2024 15:07
@dyniec
Copy link
Contributor Author

dyniec commented Jun 9, 2024

Bodigrim approach seems to be working, I will replace this PR with that version

@dyniec dyniec force-pushed the sequential_test branch from 592bcc9 to c82cb75 Compare June 10, 2024 09:21
@fendor
Copy link
Collaborator

fendor commented Aug 7, 2024

@dyniec Any update on this? Do you need help with anything?

@dyniec
Copy link
Contributor Author

dyniec commented Aug 21, 2024

I completely forgot about this PR. Sorry about that. I fix this PR soon

fendor
fendor approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, the PR is ready for merge, right?

@fendor
Copy link
Collaborator

fendor commented Oct 9, 2024 •
edited
Loading

Seems like we need to bump the tasty version in stackage?

haskell-language-server> 
haskell-language-server> /root/build/ghcide/test/exe/Main.hs:105:40: error: [GHC-88464]
haskell-language-server>     Variable not in scope:
haskell-language-server>       sequentialTestGroup :: t0 -> DependencyType -> [a0] -> TestTree
haskell-language-server>     |
haskell-language-server> 105 |        PlusTestOptions mkSequential _ =sequentialTestGroup "foo" AllFinish []
haskell-language-server>     |                                        ^^^^^^^^^^^^^^^^^^^

https://app.circleci.com/pipelines/github/haskell/haskell-language-server/13176/workflows/f8058e95-bc4f-4f49-bd47-290d42b9b284/jobs/68149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyniec @fendor