Teach HLS about different file extensions #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
reviewed
Jun 10, 2022
pepeiborra
reviewed
Jun 10, 2022
pepeiborra
approved these changes
Jun 10, 2022
|
Yeah, the companion PR is here: haskell/vscode-haskell#618 |
fendor
force-pushed
the
feature/cabal-file-support
branch
from
386bf8a
to
99dc22e
Compare
michaelpj
reviewed
Jun 10, 2022
VeryMilkyJoe
force-pushed
the
feature/cabal-file-support
branch
from
f514d2e
to
a9041fc
Compare
fendor
commented
Jun 20, 2022
| @@ -6714,7 +6714,7 @@ unitTests recorder logger = do | |||
| ] ++ Ghcide.descriptors (cmapWithPrio LogGhcIde recorder) | |||
|
|
|||
| testIde recorder (IDE.testing (cmapWithPrio LogIDEMain recorder) logger){IDE.argsHlsPlugins = plugins} $ do | |||
| _ <- createDoc "haskell" "A.hs" "module A where" | |||
| _ <- createDoc "A.hs" "haskell" "module A where" | |||
There was a problem hiding this comment.
fendor
force-pushed
the
feature/cabal-file-support
branch
from
cea8009
to
8506c27
Compare
michaelpj
reviewed
Jun 20, 2022
michaelpj
reviewed
Jun 20, 2022
michaelpj
reviewed
Jun 20, 2022
fendor
force-pushed
the
feature/cabal-file-support
branch
from
8506c27
to
9d2b79d
Compare
fendor
force-pushed
the
feature/cabal-file-support
branch
3 times, most recently
from
dc3d7c2
to
3b6b472
Compare
NotificationHandler now distinguishes between different file extensions RequestHandler distinguishes between different file extensions
The hierarchy looks as follows:
PluginMethod (pluginEnabled)
|
-----------------------------------
| |
PluginRequestMethod PluginNotificationMethod
fendor
force-pushed
the
feature/cabal-file-support
branch
from
3b6b472
to
e7e60bc
Compare
fendor
force-pushed
the
feature/cabal-file-support
branch
from
cfe643e
to
dd56166
Compare
|
@michaelpj Thank you for your time and thorough reviews! |
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* Fix parameter switch-up
* Generalise file extension handling for plugins
NotificationHandler now distinguishes between different file extensions
RequestHandler distinguishes between different file extensions
* Introduce PluginMethod Typeclass hierarchy
The hierarchy looks as follows:
PluginMethod (pluginEnabled)
|
-----------------------------------
| |
PluginRequestMethod PluginNotificationMethod
* Add example plugin
* Improve documentation for plugins
* Simplify Plugin Handling code
Co-authored-by: Jana Chadt <[email protected]>
Co-authored-by: Jana Chadt <[email protected]>
Co-authored-by: Fendor <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the foundation for #2940 and as such, I'd be really happy if we could get a review here before ZuriHac :)
I am working on a minimal example Plugin, that should illustrate that stuff works by tomorrow.
The Idea is to teach
PluginDescriptorsabout the file-extension.This PR is currently untested and only cherry-picked from #2047, the example plugin will have to suffice as tests.