-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split OsString into separate package #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have bandwidth to look into details, but the split sounds good to me.
The caveat is this: if a user adds both filepath and os-string to their dependencies they may get compile error if using modules that exist in both, due to deprecation period. That can easily be fixed with PackageImports. But it isn't a breaking change, technically. In order to push people into using os-string, I'd prefer to not release the bytestring API in filepath. |
It also means: after the deprecation period, we'll have to do a major PVP bump to filepath, incurring some maintenance cost to stackage etc. |
The other options is to rename all module prefixes |
6bf0057
to
81d2872
Compare
Since #202 introduces significant new API that really doesn't belong into filepath anymore, I want to split out the packages
This means GHC will need a new boot package
os-string
: https://github.com/haskell/os-string@bgamari @mpickering @Bodigrim