Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newer warning flags #10743

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Use newer warning flags #10743

merged 1 commit into from
Jan 26, 2025

Conversation

philderbeast
Copy link
Collaborator

Fixes #10742.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

ulysses4ever
ulysses4ever approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a horrendous number of these we have...

@philderbeast philderbeast force-pushed the deprecated/fwarn branch 2 times, most recently from 6be933e to 2b8fdf7 Compare January 16, 2025 18:51
@philderbeast philderbeast requested a review from ffaf1 January 16, 2025 18:51
@philderbeast philderbeast force-pushed the deprecated/fwarn branch 2 times, most recently from 8a342df to d1c112d Compare January 24, 2025 11:21
@philderbeast
Copy link
Collaborator Author

@Mikolaj while it is quiet, could be a good time to get these changes through?

@philderbeast
Copy link
Collaborator Author

@ffaf1 and @ulysses4ever do you think we should keep the 3 commits? Currently one is for **/Z.hs, another is for the Paths_pkgs template and then the 3rd is for all the other *.hs files. Happy to keep or squash.

No need for a warning about needing ghc >= 8 that the newer warning syntax needs as that has already been announced in prior release notes.

cabal/release-notes/Cabal-3.12.0.0.md

Line 76 in 682c54a

- Cabal and Cabal-syntax 3.12 support GHC version 8.4.4 and up.

@ffaf1
Copy link
Collaborator

ffaf1 commented Jan 24, 2025

I would squash, I see no benefit in having multiple commits in this case.

@philderbeast
Use newer -W and -Wno- warning flags
f47768a 
- Use newer warning flags in Paths_pkg template
- Use newer warning flags in **/Z.hs
@ulysses4ever
Copy link
Collaborator

Same.

@philderbeast
Copy link
Collaborator Author

Label merge+no rebase is necessary when the pull request is from an organisation.

@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jan 24, 2025
@mergify mergify bot merged commit 0de8459 into haskell:master Jan 26, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffaf1 ffaf1 ffaf1 approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using deprecated -fwarn- flags
3 participants
@philderbeast @ffaf1 @ulysses4ever