Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eq and Ord instance for Builder #677

Closed
wants to merge 1 commit into from
Closed

Eq and Ord instance for Builder #677

wants to merge 1 commit into from

Conversation

BebeSparkelSparkel
Copy link
Contributor

@BebeSparkelSparkel BebeSparkelSparkel commented May 5, 2024 •
edited
Loading

Text's Builder has these instances and it is very useful for testing.

closes #676

@BebeSparkelSparkel
Copy link
Contributor Author

@clyring Any thoughts on this small addition?

@clyring
Copy link
Member

clyring commented Jun 5, 2024

I can see the convenience of having this instance. But Builder is more like a function than a data structure, which means for example that multiple comparisons involving one Builder generally cannot expect to share any of the encoding work. It does seem reasonable to continue asking users to execute any Builders with toLazyByteString before comparing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eq and Ord for Builder
2 participants
@BebeSparkelSparkel @clyring