Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instance IsList Builder #672

Merged
merged 1 commit into from
Jun 20, 2024
Merged

instance IsList Builder #672

merged 1 commit into from
Jun 20, 2024

Conversation

BebeSparkelSparkel
Copy link
Contributor

No description provided.

@BebeSparkelSparkel
Copy link
Contributor Author

Master seems to have a problem building.

@clyring
Copy link
Member

clyring commented Apr 11, 2024

Master is fine; the problem is that TypeFamilies implies MonoLocalBinds. Add necessary type signatures or add NoMonoLocalBinds and things will work again.

clyring
clyring reviewed Apr 13, 2024
View reviewed changes
Data/ByteString/Builder/Internal.hs Outdated Show resolved Hide resolved
Data/ByteString/Builder/Internal.hs Outdated Show resolved Hide resolved
Data/ByteString/Builder/Internal.hs Outdated Show resolved Hide resolved
clyring
clyring reviewed Apr 14, 2024
View reviewed changes
Data/ByteString/Builder/Internal.hs Outdated Show resolved Hide resolved
Data/ByteString/Builder/Internal.hs Outdated Show resolved Hide resolved
@BebeSparkelSparkel BebeSparkelSparkel force-pushed the islist-builder branch 5 times, most recently from 909c245 to 9184626 Compare April 14, 2024 18:42
@BebeSparkelSparkel
Copy link
Contributor Author

I think I resolved all the issues for this. Is there anything else that you think needs to be done?

@clyring
Copy link
Member

clyring commented Jun 20, 2024

I don't know what's going on with CI.

haddock: internal error: /home/runner/.cabal/store/ghc-9.2.8/data-array-byte-0.1.0.1-f831171dcc4d41dc107971690114281a96e4f99195c8d6f16c141f20becc190b/share/doc/html/doc-index.json: openBinaryFile: does not exist (No such file or directory)

master is still green and I don't see how this patch might relate to the error. @BebeSparkelSparkel can you try merging in or rebasing onto the latest master again? I'm really hoping the problem will just go away.

@Bodigrim Bodigrim merged commit d1aebfb into haskell:master Jun 20, 2024
27 checks passed
@Bodigrim
Copy link
Contributor

Thanks @BebeSparkelSparkel!

Bodigrim pushed a commit that referenced this pull request Oct 9, 2024
@BebeSparkelSparkel @Bodigrim
instance IsList Builder (#672)
0b65c18
Bodigrim pushed a commit that referenced this pull request Oct 15, 2024
@BebeSparkelSparkel @Bodigrim
instance IsList Builder (#672)
6f33115
@Bodigrim Bodigrim added this to the 0.12.2.0 milestone Oct 15, 2024
@clyring clyring mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clyring clyring clyring approved these changes

@Bodigrim Bodigrim Bodigrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BebeSparkelSparkel @clyring @Bodigrim