-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline nix-derivation
(and PRs), extend
#289
Draft
Ericson2314
wants to merge
67
commits into
haskell-nix:master
Choose a base branch
from
obsidiansystems:derivation-work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is not always a `FilePath`. For example, `builder` can be `"builtins.fetchURL`
* Expose parseDerivationWith, buildDerivationWith and textParser * Version 1.1.0 → 1.1.1 (haskell-nix#8)
Only including instructions for Nix, since if you're using this project I think it's safe to assume you'll have Nix available.
This was referenced Nov 1, 2024
What I've started doing is
|
- The type is now in `hnix-store-core` - The serialization logic (the rest of `nix-derivation`) is now called `hnix-store-aterm` Most type errors are fixed.
The example sorted names before hashes, but `Nix` (at least these days) and `hnix-store` do not do that. Delete the redundant copies in `hnix-store-core`
OK @sorki this now build completely, but I have introduced a regression in the daemon test suite. |
This is to avoid conflict with the type which is actually a derivations output field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #288