Add support for AWS VPN connections. #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Wait for the connection to become available. This has an obscenely | ||
| // high default timeout because AWS VPN connections are notoriously | ||
| // slow at coming up or going down. There's also no point in checking | ||
| // more frequently than every ten seconds. |
There was a problem hiding this comment.
Thanks for this extra context in the comment. Super helpful for future humans in here.
|
Minus the newline, this is looking incredibly solid. Seeing a PR this good... brings a tear to my eye. 😂 I'm just going to merge and fix the newline myself, because this code deserves the big green button. |
phinze
added a commit
that referenced
this pull request
May 2, 2015
Add support for AWS VPN connections.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work for #28 and also addresses #551. Last resource (possibly) needed for VPN support is vpn connection routes, which I'm working on now. Should be very simple. They're extremely minimalist.
This is by far the most complicated resource I've contributed, so it probably warrants a close look. I've done a lot of testing on it, however.
As an aside, the reason I'm cranking these out is we're pushing our entire infrastructure into terraform over at Conductor, Inc., and we're so excited about this project we thought we'd build anything we still needed.