Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry billing update in project creation #1131

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

crhino
Copy link
Contributor

@crhino crhino commented Nov 12, 2024

HCPF-2286

🛠️ Description

Building the provider locally and running many project creations at once, I see:

2024-11-14T10:39:46.626-0500 [DEBUG] provider.terraform-provider-hcp: {"code":14, "message":"failed to update billing account", "details":[]}
2024-11-14T10:39:46.626-0500 [WARN]  unexpected data: localhost/providers/hcp:stdout="Error trying to update billing account. Retrying in 10 seconds..."

and that all projects create successfully given time:

hcp_project.proj["project16"]: Creation complete after 1s [name=project16]
hcp_project.proj["project10"]: Still creating... [10s elapsed]
hcp_project.proj["project12"]: Still creating... [10s elapsed]
hcp_project.proj["project12"]: Creation complete after 11s [name=project12]
hcp_project.proj["project10"]: Creation complete after 11s [name=project10]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...
=== RUN   TestAccProjectResource
--- PASS: TestAccProjectResource (5.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager	8.092s

@crhino crhino marked this pull request as ready for review November 14, 2024 16:06
@crhino crhino requested review from a team as code owners November 14, 2024 16:06
@pierluc-codes
Copy link
Contributor

pierluc-codes commented Nov 15, 2024

@crhino can you explain why the retries are necessary? Especially on a 503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants