-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Figma v2.0 changelog to the website #2653
Open
jorytindall
wants to merge
9
commits into
main
Choose a base branch
from
hds-4175-add-figma-v2-changelog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+566
โ11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
hashibot-hds
added
packages/components
docs-website
Content updates to the documentation website
labels
Jan 16, 2025
andgen404
reviewed
Jan 22, 2025
Comment on lines
+13
to
+27
#### General changes | ||
|
||
- Improved consistency in component naming conventions | ||
- Enhanced property panel customization options | ||
- Reduced variant complexity through boolean properties | ||
- Added local tokens for custom styling (hidden from publishing) | ||
- Standardized nested component structure | ||
|
||
#### Component organization updates | ||
|
||
- Form components now use "Form /" prefix instead of table of contents structure | ||
- Dialog-based components (Modal, Flyout) now use DialogPrimitive as base | ||
- Added [Template] components for common component combinations | ||
- Improved nested component exposure for easier customization | ||
- Standardized boolean property usage across components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] to maybe reduce the amount of text here and combine it?
Suggested change
#### General changes | |
- Improved consistency in component naming conventions | |
- Enhanced property panel customization options | |
- Reduced variant complexity through boolean properties | |
- Added local tokens for custom styling (hidden from publishing) | |
- Standardized nested component structure | |
#### Component organization updates | |
- Form components now use "Form /" prefix instead of table of contents structure | |
- Dialog-based components (Modal, Flyout) now use DialogPrimitive as base | |
- Added [Template] components for common component combinations | |
- Improved nested component exposure for easier customization | |
- Standardized boolean property usage across components | |
#### General and Organizational updates | |
- Standardized naming conventions, nested structures, and boolean property usage to reduce complexity. | |
- Enhanced property panel options with added hidden local tokens for custom styling. | |
- Updated organization with "Form /" prefixes and DialogPrimitive as the base for modal components. | |
- Introduced [Template] components for common combinations. | |
- Improved nested component accessibility for easier customization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Summary
This PR adds all of the consumer-relevant changes in the Figma v2.0 Library project to the changelog.
๐ ๏ธ Detailed description
This is a lot of content, I tried to keep things concise where possible and maintain consistent formatting through the document. However, due breadth of updates, there may be some places where I missed something.
I also introduced some slightly ~~~different~~~ new formatting compared to the rest of the entries in an effort to break things up a bit a better and introduce some more hierarchy. The content is organized in three core sections:
I'm open to feedback on how to trim this down or if this formatting makes sense!
๐ External links
Jira ticket: HDS-4175
๐ฌ Please consider using conventional comments when reviewing this PR.