Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: Advanced Table testing #2652

Closed
wants to merge 46 commits into from
Closed

DO NOT MERGE: Advanced Table testing #2652

wants to merge 46 commits into from

Conversation

shleewhite
Copy link
Contributor

📌 Summary

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

shleewhite added 30 commits January 13, 2025 17:33
chore: add changeset
309ec18
feat: copy Hds::Table and rework to Hds::AdvancedTable
136717b
feat: copy tests from Table and rework for AdvancedTable
d482373
feat: copy showcase from Table and rework for AdvancedTable
7c2c054
feat: add keyboard navigation + related tests
df78fbc
feat: add @hasStickyHeader argument and related showcase example, test
d575759
feat: add nested rows, @childrenKey arg
3ccc579
chore: skip sticky header test for now
a3bdd2c
fix: add cleanup for IntersectionObserver
ed617a0
feat: use ember-focus-trap and tabbable libraries
edce8b4
fix: restore tabindex correctly when switch between mode
32caaa7
chore: remove pauseTest
fbfaec5
chore: incorporate feedback for advanced-table/index.hbs
3916f1f
chore: lint showcase
7b494df
chore: lint components
f7488ba
fix: revert didInsertCheckbox arg name
f64e850
chore: remove jsdocs
b44eab8
chore: update changeset
7878f04
fix: deactivate focus trap when click outside the cell
4387ba5
feat: use flexbox to mimic vertical-align
808ba90
chore: improve valign tests
8c4c503
fix: content showing behind sticky header
72fecb2
fix: animate selected users showcase example
3c71653
chore: lint
5620c1e
feat: add showcase example for dynamic cell content
4845724
chore: lint
97a4568
fix: sticky header styles
d4ae07d
feat: add mutationObserver for when focusable content in cell changes
eebdccc
fix: bad rebase in yarn lock
4c6048d
chore: lint
4efb87c
@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jan 16, 2025 8:00pm
hds-website ✅ Ready (Inspect) Visit Preview Jan 16, 2025 8:00pm

@shleewhite shleewhite force-pushed the test/advanced-table-build branch from 60f3af5 to 4b58ccd Compare January 16, 2025 19:40
Base automatically changed from hds-3965/advanced-table-clean to main January 21, 2025 16:51
@shleewhite shleewhite closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/components showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shleewhite @hashibot-hds