Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Lee White <[email protected]>
  • Loading branch information
2 people authored and shleewhite committed Jan 22, 2025
1 parent 4c93707 commit d071f18
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Use left alignment for:
- Numerical values that contain periods or other delimiter characters (IP addresses).
- Nested components that display a string or text value, e.g., a [Badge](/components/badge).

![Left alignment of content within an Advanced Table](/assets/components/table/advanced-table/start-alignment-example.png)
![](/assets/components/table/advanced-table/start-alignment-example.png)

#### Right alignment

Expand All @@ -98,7 +98,7 @@ Common examples of right alignment include:
- Financial information and currency amounts.
- Fractional and floating point values represented with decimals.

![Right alignment of content within a table](/assets/components/table/advanced-table/end-alignment-example.png)
![](/assets/components/table/advanced-table/end-alignment-example.png)

Right alignment can also be used in the last column of an advanced table to:

Expand Down Expand Up @@ -163,7 +163,7 @@ Use expandable rows to display hierarchical data efficiently. This allows users

Avoid using expandable rows when data is not structured in parent-child relationships.

![Advanced Table column placement example](/assets/components/table/advanced-table/advanced-table-dont-parent-nested.png)
![Advanced Table where the parent row has cells for name and email, but children rows have cells containing order date and total.](/assets/components/table/advanced-table/advanced-table-dont-parent-nested.png)

!!!

Expand All @@ -178,7 +178,7 @@ Use the same density setting for parent and child rows to keep layouts consisten

!!! Dont

![Tall cell density mixed with short density rows. ](/assets/components/table/advanced-table/advanced-table-density-mix.png)
![Advanced Table with default height parent rows and short density nested rows.](/assets/components/table/advanced-table/advanced-table-density-mix.png)

!!!

Expand All @@ -191,7 +191,7 @@ Ensure that content within striped rows continue to maintain adequate color cont

!!!

![Table striping examples](/assets/components/table/advanced-table/advanced-table-striping.png)
![Advanced Tables with row striping have rows that alternate between white and light grey background color.](/assets/components/table/advanced-table/advanced-table-striping.png)

Striping enhances readability by alternating row colors, making it easier to scan tabular data.

Expand Down Expand Up @@ -251,11 +251,11 @@ When the user is in navigation mode, pressing enter will activate action mode, w

## Multi-Select

Multi-select allows users to select multiple rows to perform bulk actions, such as deleting or exporting data. The Advanced Table maintains selection states across pagination and filtering, ensuring consistency when interacting with large datasets.
Multi-select allows users to select multiple rows to perform bulk actions, such as deleting or exporting data. The Advanced Table maintains selection states across pagination and filtering, ensuring consistency when interacting with large datasets. For more details, check out the [Multi-Select Table Pattern.](https://helios.hashicorp.design/patterns/table-multi-select)

!!! Info

However, multi-select and sorting are not supported for nested rows at this time. For more details, check out the [Multi-Select Table Pattern.](https://helios.hashicorp.design/patterns/table-multi-select)
Multi-select and sorting are not supported for nested rows at this time.

!!!

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

| Element | Usage |
|--------------|----------|
| Indentation | Required |
| Nested | Required |
| Cell content | Required |
| Icon | Optional |
| Container | Required |
Expand Down

0 comments on commit d071f18

Please sign in to comment.