-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding besu local node config #617
Conversation
Signed-off-by: Stefan Stefanov <[email protected]>
Test Results 15 files + 1 75 suites +7 8m 15s ⏱️ +44s For more details on these failures, see this check. Results for commit cf9962f. ± Comparison against base commit fa4384e. ♻️ This comment has been updated with latest results. |
Hi @stefan-stefanooov could you please update the description of the PR as well as the issue #616? They are unclear on what the purposes of including the besu local node. Also like @Nana-EC said I think some sort of documentation which showcase the usage and the purpose of the node would be necessary. |
Hey Logan (@quiet-node) On the second part of your comment. I am not sure what I need to document here. Can you or @Nana-EC please elaborate on what exactly needs documenting here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG single comment answering your question on what to document
Signed-off-by: Stefan Stefanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Description:
Adding Besu local node configuration.
This is just for convenience of the user.
Currently we have in our hardhat.config.js configurations for 3 networks. (local, testnet, previewnet)
This task is going to add a 4th one. For a Local Besu instance (if the user of the repo has one)
This local Besu instance is useful for debugging when a problem with our Local Node is identified.
You can double check our smart contract tests against the pure Besu node.
Related issue(s):
Add Besu local node configuration #616