Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding besu local node config #617

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

stefan-stefanooov
Copy link
Contributor

@stefan-stefanooov stefan-stefanooov commented Dec 6, 2023

Description:
Adding Besu local node configuration.
This is just for convenience of the user.

Currently we have in our hardhat.config.js configurations for 3 networks. (local, testnet, previewnet)
This task is going to add a 4th one. For a Local Besu instance (if the user of the repo has one)
This local Besu instance is useful for debugging when a problem with our Local Node is identified.
You can double check our smart contract tests against the pure Besu node.

Related issue(s):
Add Besu local node configuration #616

@stefan-stefanooov stefan-stefanooov added enhancement New feature or request Limechain Items for Limechain team labels Dec 6, 2023
@stefan-stefanooov stefan-stefanooov added this to the 0.7.0 milestone Dec 6, 2023
@stefan-stefanooov stefan-stefanooov self-assigned this Dec 6, 2023
@stefan-stefanooov stefan-stefanooov requested a review from a team as a code owner December 6, 2023 11:45
@stefan-stefanooov stefan-stefanooov linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 6, 2023

Test Results

  15 files  +  1    75 suites  +7   8m 15s ⏱️ +44s
214 tests ±  0  207 ✔️ +  1  6 💤 ±0  1  - 1 
230 runs  +16  221 ✔️ +15  8 💤 +2  1  - 1 

For more details on these failures, see this check.

Results for commit cf9962f. ± Comparison against base commit fa4384e.

♻️ This comment has been updated with latest results.

@quiet-node
Copy link
Member

Hi @stefan-stefanooov could you please update the description of the PR as well as the issue #616? They are unclear on what the purposes of including the besu local node. Also like @Nana-EC said I think some sort of documentation which showcase the usage and the purpose of the node would be necessary.

@stefan-stefanooov
Copy link
Contributor Author

Hi @stefan-stefanooov could you please update the description of the PR as well as the issue #616? They are unclear on what the purposes of including the besu local node. Also like @Nana-EC said I think some sort of documentation which showcase the usage and the purpose of the node would be necessary.

Hey Logan (@quiet-node)
I updated the description. Highlight this is just for convenience.

On the second part of your comment. I am not sure what I need to document here.
The besu local node has its own documentation so I some dev wants to bring it up in his local evn they just need to follow it.
Same as the Hedera Local node. We don't provide any documentation on how to bring it up in this repo.

Can you or @Nana-EC please elaborate on what exactly needs documenting here?

Nana-EC
Nana-EC previously approved these changes Dec 7, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG single comment answering your question on what to document

hardhat.config.js Show resolved Hide resolved
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@stefan-stefanooov stefan-stefanooov merged commit dca9ec5 into main Dec 7, 2023
21 of 22 checks passed
@stefan-stefanooov stefan-stefanooov deleted the 616-add-besu-local-node-configuration branch December 7, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Limechain Items for Limechain team
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Besu local node configuration
3 participants