test: validate contract and admin key in hollow account finalized as contract #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contract Signed-off-by: Nadezhda Popova <[email protected]>
nadezhdapopovaa
requested review from
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0 and
a team
as code owners
quiet-node
reviewed
Jan 6, 2025
|
Let’s not forget the assignees and additional PR details. |
…zed as contract Signed-off-by: Nadezhda Popova <[email protected]>
|
@lukelee-sl please review the PR when you have a chance to see if it aligns with your vision for this feature. |
lukelee-sl
reviewed
Jan 7, 2025
nadezhdapopovaa
changed the title
…out finalizing a hollow account Signed-off-by: Nadezhda Popova <[email protected]>
natanasow
reviewed
Jan 16, 2025
natanasow
reviewed
Jan 16, 2025
natanasow
reviewed
Jan 16, 2025
…ct without finalizing a hollow account Signed-off-by: Nadezhda Popova <[email protected]>
… contract without finalizing a hollow account Signed-off-by: Nadezhda Popova <[email protected]>
lukelee-sl
approved these changes
Jan 16, 2025
nadezhdapopovaa
requested review from
konstantinabl,
natanasow and
Ferparishuertas
natanasow
approved these changes
Jan 17, 2025
nadezhdapopovaa
deleted the
1007-create-test-to-validate-contract-admin-key-in-hollow-account-finalized-as-contract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added test for admin key and contract id validation (should be the same) after deploying a contract with hollow account.
Related issue(s):
Fixes #1007