Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain override values on ConfigProviderImpl.update() (#17424) #17430

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

tinker-michaelj
Copy link
Collaborator

Cherry-pick #17424

@tinker-michaelj tinker-michaelj requested a review from a team as a code owner January 17, 2025 16:47
@tinker-michaelj tinker-michaelj added this to the v0.58 milestone Jan 17, 2025
@tinker-michaelj tinker-michaelj self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.35%. Comparing base (ad53b0c) to head (6d62597).
Report is 1 commits behind head on release/0.58.

Files with missing lines Patch % Lines
.../hedera/node/app/workflows/FacilityInitModule.java 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.58   #17430   +/-   ##
===============================================
  Coverage           64.35%   64.35%           
- Complexity          20914    20915    +1     
===============================================
  Files                2549     2549           
  Lines               96049    96055    +6     
  Branches            10048    10048           
===============================================
+ Hits                61812    61816    +4     
- Misses              30601    30604    +3     
+ Partials             3636     3635    -1     
Files with missing lines Coverage Δ
...com/hedera/node/app/config/ConfigProviderImpl.java 93.54% <100.00%> (+0.32%) ⬆️
...n/java/com/hedera/node/app/util/FileUtilities.java 86.95% <ø> (ø)
.../hedera/node/app/workflows/FacilityInitModule.java 28.00% <0.00%> (-1.79%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 42.86%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ad53b0c) 95812 65256 68.11%
Head commit (6d62597) 95818 (+6) 65259 (+3) 68.11% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17430) 7 3 42.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tinker-michaelj tinker-michaelj merged commit d8a0c10 into release/0.58 Jan 21, 2025
47 of 55 checks passed
@tinker-michaelj tinker-michaelj deleted the r58-cherry-pick-17424 branch January 21, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants