-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable NFT Airdrop to distribute multiple serials #17413
Conversation
Signed-off-by: Stanimir Stoyanov <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd like to see a test with multiple airdrops where one or more (but not all, and not the first in the list) fail.
...a/com/hedera/services/bdd/suites/contract/precompile/airdrops/AirdropSystemContractTest.java
Outdated
Show resolved
Hide resolved
...a/com/hedera/services/bdd/suites/contract/precompile/airdrops/AirdropSystemContractTest.java
Show resolved
Hide resolved
...a/com/hedera/services/bdd/suites/contract/precompile/airdrops/AirdropSystemContractTest.java
Show resolved
Hide resolved
Signed-off-by: Stanimir Stoyanov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17413 +/- ##
============================================
+ Coverage 68.69% 68.99% +0.29%
- Complexity 22520 22771 +251
============================================
Files 2605 2619 +14
Lines 96927 98272 +1345
Branches 10101 10184 +83
============================================
+ Hits 66586 67800 +1214
- Misses 26535 26644 +109
- Partials 3806 3828 +22
|
...ra/node/app/service/contract/impl/exec/systemcontracts/hts/airdrops/TokenAirdropDecoder.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a comment on an additional test if possible.
Signed-off-by: Stanimir Stoyanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. tyvm.
Description:
This PR fixes the limit of one NFT serial Airdropped with a single transaction.
WIth this logic we can now distribute a NFT to multiple receivers.
The configured limits for airdrops are still applied here.
Related issue(s):
Fixes #17409
Notes for reviewer:
Checklist