Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase code coverage in CryptoGetAccountRecordsHandler #17411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Jan 16, 2025

Description:
Code coverage increased from 72.09% to 95.35%

Related issue(s):

Fixes #17410

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@petreze petreze added this to the v0.59 milestone Jan 16, 2025
@petreze petreze self-assigned this Jan 16, 2025
@petreze petreze requested a review from a team as a code owner January 16, 2025 14:10
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9142a70) 96670 69527 71.92%
Head commit (ee12f9d) 96670 (+0) 69538 (+11) 71.93% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17411) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.05%. Comparing base (9142a70) to head (ee12f9d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17411      +/-   ##
============================================
+ Coverage     68.04%   68.05%   +0.01%     
- Complexity    22387    22390       +3     
============================================
  Files          2605     2605              
  Lines         96887    96887              
  Branches      10098    10098              
============================================
+ Hits          65927    65937      +10     
+ Misses        27208    27197      -11     
- Partials       3752     3753       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage in CryptoGetAccountRecordsHandler
1 participant