-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fee for topic with custom fee creation #17407
base: hip-991-topic-fees
Are you sure you want to change the base?
Conversation
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hip-991-topic-fees #17407 +/- ##
========================================================
- Coverage 67.57% 67.57% -0.01%
- Complexity 22159 22168 +9
========================================================
Files 2589 2589
Lines 96757 96774 +17
Branches 10126 10131 +5
========================================================
+ Hits 65385 65396 +11
- Misses 27616 27620 +4
- Partials 3756 3758 +2
|
Signed-off-by: ibankov <[email protected]>
...est-clients/src/main/java/com/hedera/services/bdd/suites/fees/ConsensusServiceFeesSuite.java
Show resolved
Hide resolved
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
* createTopicTxBody.getAutoRenewPeriod().getSeconds(); | ||
// Scale the rbs based on topic size and custom fees | ||
extraRbsServices = | ||
(getTopicRamBytes(variableSize) + bytesNeededToRepr(createTopicTxBody.getCustomFeesList())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit : bytesNeededToRepr(createTopicTxBody.getCustomFeesList()))
can be added inside getTopicRamBytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
Adding fee for creating topic with custom fees. The fee should be 2$.
Related issue(s):
#17393
Fixes #
#17393
Notes for reviewer:
Checklist