Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick: FileService address book and node details should be updated at genesis #17368

Open
wants to merge 1 commit into
base: release/0.58
Choose a base branch
from

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Jan 14, 2025

Description:

Cherry pick #17278
Related issue(s):

Fixes #17247

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…enesis (#17278)

Signed-off-by: Iris Simon <[email protected]>
(cherry picked from commit 84c5adf)
@iwsimon iwsimon added this to the v0.59 milestone Jan 14, 2025
@iwsimon iwsimon self-assigned this Jan 14, 2025
@iwsimon iwsimon requested review from a team as code owners January 14, 2025 13:36
@iwsimon iwsimon requested a review from kimbor January 14, 2025 13:36
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4e7c354) 95773 65216 68.09%
Head commit (4450dc3) 95751 (-22) 65189 (-27) 68.08% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17368) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.32%. Comparing base (4e7c354) to head (4450dc3).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.58   #17368      +/-   ##
==================================================
- Coverage           64.33%   64.32%   -0.02%     
+ Complexity          20911    20906       -5     
==================================================
  Files                2549     2549              
  Lines               96010    95988      -22     
  Branches            10047    10047              
==================================================
- Hits                61771    61745      -26     
- Misses              30602    30607       +5     
+ Partials             3637     3636       -1     
Files with missing lines Coverage Δ
.../node/app/workflows/handle/record/SystemSetup.java 91.03% <100.00%> (-0.44%) ⬇️
...ra/node/app/service/file/impl/FileServiceImpl.java 100.00% <100.00%> (ø)
...ice/file/impl/handlers/FileGetContentsHandler.java 95.52% <100.00%> (+0.06%) ⬆️
...app/service/file/impl/schemas/V0490FileSchema.java 88.06% <100.00%> (-0.77%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

@iwsimon iwsimon changed the title fix: FileService address book and node details should be updated at genesis fix: cherry-pick: FileService address book and node details should be updated at genesis Jan 14, 2025
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @iwsimon !

@olsentorfinn
Copy link

We will delay merging this PR until Thursday 01/16 to enable the solo team a deployment with the present unmodified release.

@olsentorfinn
Copy link

Due to the release of .57 to mainnet slipping and some additional solo testing this will need to be held until 01/22 and confirmation of successful Solo AWS Sphere release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants