-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cherry-pick: FileService address book and node details should be updated at genesis #17368
base: release/0.58
Are you sure you want to change the base?
Conversation
…enesis (#17278) Signed-off-by: Iris Simon <[email protected]> (cherry picked from commit 84c5adf)
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.58 #17368 +/- ##
==================================================
- Coverage 64.33% 64.32% -0.02%
+ Complexity 20911 20906 -5
==================================================
Files 2549 2549
Lines 96010 95988 -22
Branches 10047 10047
==================================================
- Hits 61771 61745 -26
- Misses 30602 30607 +5
+ Partials 3637 3636 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @iwsimon !
We will delay merging this PR until Thursday 01/16 to enable the solo team a deployment with the present unmodified release. |
Due to the release of .57 to mainnet slipping and some additional solo testing this will need to be held until 01/22 and confirmation of successful Solo AWS Sphere release. |
Description:
Cherry pick #17278
Related issue(s):
Fixes #17247
Notes for reviewer:
Checklist