Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update usage of root level version.txt file #17366

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

mishomihov00
Copy link
Contributor

Description:

This PR aims to configure the "node-zxc-build-release-artifact.yaml" workflow to store version.txt as artifact instead of storing it in the build cache.

Related issue(s):

Fixes #17248

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mishomihov00 mishomihov00 added this to the v0.59 milestone Jan 14, 2025
@mishomihov00 mishomihov00 self-assigned this Jan 14, 2025
@mishomihov00 mishomihov00 linked an issue Jan 14, 2025 that may be closed by this pull request
2 tasks
Copy link

codacy-production bot commented Jan 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3e8fa1f) 97675 71128 72.82%
Head commit (73ad07f) 97675 (+0) 71128 (+0) 72.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17366) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (3e8fa1f) to head (73ad07f).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17366   +/-   ##
=========================================
  Coverage     68.91%   68.91%           
  Complexity    22667    22667           
=========================================
  Files          2613     2613           
  Lines         97892    97892           
  Branches      10156    10156           
=========================================
  Hits          67463    67463           
  Misses        26613    26613           
  Partials       3816     3816           

Impacted file tree graph

@mishomihov00 mishomihov00 changed the title ci: store version.txt as artifact ci: Update usage of root level version.txt file Jan 14, 2025
@mishomihov00 mishomihov00 force-pushed the 17248-update-usage-of-root-level-versiontxt-file branch from 205351f to 93b8e11 Compare January 14, 2025 15:07
@mishomihov00 mishomihov00 marked this pull request as ready for review January 14, 2025 15:08
@mishomihov00 mishomihov00 requested review from a team as code owners January 14, 2025 15:08
@andrewb1269hg
Copy link
Contributor

This looks good to me, but I'd like @rbarkerSL to look at it as well before merging it.

@mishomihov00 mishomihov00 force-pushed the 17248-update-usage-of-root-level-versiontxt-file branch from 93b8e11 to d592477 Compare January 15, 2025 07:52
@mishomihov00 mishomihov00 merged commit 422cc1c into main Jan 22, 2025
46 checks passed
@mishomihov00 mishomihov00 deleted the 17248-update-usage-of-root-level-versiontxt-file branch January 22, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update usage of root level version.txt file
3 participants