feat: HIP-551 atomic batch transactions #17333
Conversation
Signed-off-by: Kim Rader <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17360-combine-transaction-body-proto #17333 +/- ##
==========================================================================
- Coverage 67.94% 67.94% -0.01%
- Complexity 22342 22347 +5
==========================================================================
Files 2606 2608 +2
Lines 96901 96919 +18
Branches 10098 10099 +1
==========================================================================
+ Hits 65841 65847 +6
- Misses 27295 27309 +14
+ Partials 3765 3763 -2
... and 11 files with indirect coverage changes |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Lev Povolotsky <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Lev Povolotsky <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
…ces into hip-551-batch-txs
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
…roto' into hip-551-batch-txs # Conflicts: # hapi/hedera-protobufs/services/transaction.proto
Signed-off-by: Kim Rader <[email protected]>
kimbor
changed the base branch from
17360-avoid-circular-dependency
to
17360-combine-transaction-body-proto
| import com.swirlds.config.api.ConfigProperty; | ||
|
|
||
| @ConfigData("atomicBatch") | ||
| public record AtomicBatchConfig(@ConfigProperty(defaultValue = "true") @NetworkProperty boolean isEnabled) {} |
There was a problem hiding this comment.
Maybe the default should be false? Then we can enable it when we are ready or we can enable it only on specific environments?
There was a problem hiding this comment.
I think we can change it later on before we merge it to main. this is only feature flag
| if (!handleContext | ||
| .configuration() | ||
| .getConfigData(AtomicBatchConfig.class) |
There was a problem hiding this comment.
As far as I know, this check should be done in the calculateFees method. The reason is that the calculateFees method is called on Ingest and we will throw an error early without creating an unnecessary record. This is how we implemented it for the Airdrops.
There was a problem hiding this comment.
I saw it in some other places in that place but happy to remove it to enable or disable a service
Description:
Feature branch for HIP-551 Atomic Batch Transactions
Related issue(s):
Fixes #17318
Fixes #17319
Fixes #17320
Notes for reviewer:
Checklist