Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor hapi tests to use hapiTest(...) instead of defaultHapiSpec(...) (Part 2) #16629

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mhess-swl
Copy link
Member

This PR continues the work for replacing defaultHapiSpec(...) with hapiTest(...). There should be no change to any test conditions.

Part of #16494

Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
@mhess-swl mhess-swl added this to the v0.57 milestone Nov 15, 2024
@mhess-swl mhess-swl self-assigned this Nov 15, 2024
@mhess-swl mhess-swl requested review from a team as code owners November 15, 2024 22:05
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7d4e23a) 96890 63031 65.05%
Head commit (29f9cd7) 96890 (+0) 63031 (+0) 65.05% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16629) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.32%. Comparing base (7d4e23a) to head (29f9cd7).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16629      +/-   ##
=============================================
- Coverage      63.33%   63.32%   -0.01%     
+ Complexity     20155    20149       -6     
=============================================
  Files           2536     2536              
  Lines          94071    94071              
  Branches        9836     9836              
=============================================
- Hits           59580    59573       -7     
  Misses         30902    30902              
- Partials        3589     3596       +7     

see 12 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant