Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Integrate latest cryptography library changes #16615

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Neeharika-Sompalli
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli commented Nov 15, 2024

Fixes #16587

  • Copied all the cryptography classes to services and its implementations, until snapshot is published
  • Implemented TssLibraryImpl in terms of TssService
  • Changed multiple places where PairingPrivateKey is used to BlsPrivateKey, PairingPublicKey to BlsPublicKey, PairingSignature to BlsSignature

Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 69461431 2.53%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6946143) Report Missing Report Missing Report Missing
Head commit (1fc0f6a) 98288 60429 61.48%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16615) 1584 40 2.53%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 2.33586% with 1547 lines in your changes missing coverage. Please review.

Project coverage is 59.69%. Comparing base (1ba89f5) to head (1fc0f6a).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ss/cryptography/tss/extensions/nizk/NizkProof.java 0.00% 88 Missing ⚠️
...ode/app/tss/cryptography/utils/ByteArrayUtils.java 0.00% 86 Missing ⚠️
.../tss/cryptography/altbn128/facade/FieldFacade.java 0.00% 70 Missing ⚠️
.../tss/cryptography/altbn128/facade/GroupFacade.java 0.00% 70 Missing ⚠️
.../tss/cryptography/nativesupport/NativeLibrary.java 0.00% 68 Missing ⚠️
...ptography/tss/extensions/elgamal/ElGamalUtils.java 0.00% 65 Missing ⚠️
...ryptography/tss/groth21/Groth21ShareExtractor.java 0.00% 63 Missing ⚠️
...e/app/tss/cryptography/altbn128/AltBn128Group.java 0.00% 54 Missing ⚠️
...p/tss/cryptography/tss/groth21/Groth21Message.java 0.00% 54 Missing ⚠️
...app/tss/cryptography/tss/groth21/Groth21Stage.java 0.00% 52 Missing ⚠️
... and 67 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16615      +/-   ##
=============================================
- Coverage      63.36%   59.69%   -3.67%     
+ Complexity     20162    19189     -973     
=============================================
  Files           2533     2593      +60     
  Lines          94097    95469    +1372     
  Branches        9844     9981     +137     
=============================================
- Hits           59625    56992    -2633     
- Misses         30855    34904    +4049     
+ Partials        3617     3573      -44     
Files with missing lines Coverage Δ
...rc/main/java/com/hedera/node/app/ServicesMain.java 5.40% <ø> (-28.83%) ⬇️
.../com/hedera/node/app/tss/TssDirectoryAccessor.java 26.66% <ø> (-73.34%) ⬇️
.../node/app/tss/cryptography/pairings/api/Curve.java 100.00% <100.00%> (ø)
...app/workflows/standalone/TransactionExecutors.java 31.11% <ø> (-64.45%) ⬇️
...node/app/tss/cryptography/bls/GroupAssignment.java 85.71% <85.71%> (ø)
...s/cryptography/pairings/api/PairingsException.java 0.00% <0.00%> (ø)
.../cryptography/pairings/api/curves/KnownCurves.java 83.33% <83.33%> (ø)
...de/app/tss/cryptography/tss/api/TssShareTable.java 0.00% <0.00%> (ø)
...pp/tss/cryptography/pairings/api/FieldElement.java 0.00% <0.00%> (ø)
...pp/tss/cryptography/pairings/api/GroupElement.java 0.00% <0.00%> (ø)
... and 71 more

... and 194 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Neeharika-Sompalli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate latest TssLibrary changes
1 participant