Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support DiskStartupNetworks #16594

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj tinker-michaelj added this to the v0.57 milestone Nov 13, 2024
@tinker-michaelj tinker-michaelj self-assigned this Nov 13, 2024
Signed-off-by: Michael Tinker <[email protected]>
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 50 lines in your changes missing coverage. Please review.

Project coverage is 63.35%. Comparing base (eb8b444) to head (b1fc5b0).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../com/hedera/node/app/info/DiskStartupNetworks.java 82.97% 21 Missing and 3 partials ⚠️
...va/com/hedera/node/app/tss/TssBaseServiceImpl.java 14.28% 6 Missing ⚠️
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 50.00% 3 Missing and 2 partials ⚠️
...s/platform/state/service/PlatformStateService.java 44.44% 5 Missing ⚠️
...rc/main/java/com/hedera/node/app/ServicesMain.java 60.00% 4 Missing ⚠️
...dera/node/app/services/OrderedServiceMigrator.java 0.00% 1 Missing and 1 partial ⚠️
...p/workflows/handle/steps/PlatformStateUpdates.java 86.66% 1 Missing and 1 partial ⚠️
...ddressbook/impl/schemas/V057AddressBookSchema.java 96.29% 0 Missing and 1 partial ⚠️
...latform/state/service/ReadableRosterStoreImpl.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16594      +/-   ##
=============================================
+ Coverage      63.32%   63.35%   +0.02%     
- Complexity     20140    20175      +35     
=============================================
  Files           2531     2533       +2     
  Lines          94018    94171     +153     
  Branches        9834     9837       +3     
=============================================
+ Hits           59539    59658     +119     
- Misses         30887    30922      +35     
+ Partials        3592     3591       -1     
Files with missing lines Coverage Δ
...rvice/addressbook/impl/AddressBookServiceImpl.java 100.00% <100.00%> (ø)
...ervice/addressbook/impl/ReadableNodeStoreImpl.java 100.00% <ø> (ø)
...ddressbook/impl/schemas/V053AddressBookSchema.java 96.55% <ø> (ø)
...ode/app/service/addressbook/AddressBookHelper.java 94.11% <ø> (ø)
...-app/src/main/java/com/hedera/node/app/Hedera.java 57.49% <100.00%> (-0.36%) ⬇️
...edera/node/app/config/ServicesConfigExtension.java 100.00% <ø> (ø)
.../com/hedera/node/app/info/InfoInjectionModule.java 50.00% <ø> (ø)
...ava/com/hedera/node/app/info/StateNetworkInfo.java 92.85% <ø> (-2.39%) ⬇️
...java/com/hedera/node/app/roster/RosterService.java 100.00% <100.00%> (ø)
...hedera/node/app/services/MigrationContextImpl.java 43.75% <ø> (ø)
... and 27 more

... and 6 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 86.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eb8b444) 96837 62993 65.05%
Head commit (b1fc5b0) 96990 (+153) 63112 (+119) 65.07% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16594) 300 260 86.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tinker-michaelj tinker-michaelj changed the title chore: Support DiskStartupAssets chore: Support DiskStartupNetworks Nov 14, 2024
mxtartaglia-sl
mxtartaglia-sl previously approved these changes Nov 14, 2024
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj tinker-michaelj marked this pull request as ready for review November 15, 2024 21:20
@tinker-michaelj tinker-michaelj requested review from a team as code owners November 15, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide StartupNetworks implementation for use in ServicesMain
4 participants