Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Roster Lifecycle StartupAssets #16591

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

thomas-swirlds-labs
Copy link
Contributor

Description:

Related issue(s):

Fixes #16550

Signed-off-by: Thomas Moran <[email protected]>
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.36%. Comparing base (beca90f) to head (d1c177e).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16591      +/-   ##
=============================================
+ Coverage      63.35%   63.36%   +0.01%     
  Complexity     20165    20165              
=============================================
  Files           2532     2533       +1     
  Lines          94100    94157      +57     
  Branches        9846     9867      +21     
=============================================
+ Hits           59616    59664      +48     
+ Misses         30873    30867       -6     
- Partials        3611     3626      +15     

see 22 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (beca90f) 96919 63089 65.09%
Head commit (d1c177e) 96891 (-28) 63082 (-7) 65.11% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16591) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Thomas Moran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create StartupAssets interface for inputs to startup phase
1 participant