Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Long term schedule timestamps #16580

Draft
wants to merge 3 commits into
base: 15055-POC-long-term-scheduled-transactions
Choose a base branch
from

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Nov 13, 2024

Description:
Calculate correctly scheduled transactions following/preceding child records timestamps.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ibankov ibankov added this to the v0.57 milestone Nov 13, 2024
@ibankov ibankov self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.32%. Comparing base (046ca88) to head (0847ded).

Files with missing lines Patch % Lines
...dera/node/app/workflows/handle/HandleWorkflow.java 61.90% 8 Missing ⚠️
...hedera/node/app/workflows/handle/HandleOutput.java 0.00% 1 Missing ⚠️
...app/workflows/handle/stack/SavepointStackImpl.java 50.00% 1 Missing ⚠️
...flows/handle/stack/savepoints/BuilderSinkImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##             15055-POC-long-term-scheduled-transactions   #16580      +/-   ##
================================================================================
- Coverage                                         63.32%   63.32%   -0.01%     
- Complexity                                        20128    20131       +3     
================================================================================
  Files                                              2529     2529              
  Lines                                             93913    93921       +8     
  Branches                                           9829     9829              
================================================================================
+ Hits                                              59468    59471       +3     
- Misses                                            30841    30847       +6     
+ Partials                                           3604     3603       -1     
Files with missing lines Coverage Δ
...a/node/app/workflows/handle/stack/BuilderSink.java 100.00% <ø> (ø)
...hedera/node/app/workflows/handle/HandleOutput.java 87.50% <0.00%> (-12.50%) ⬇️
...app/workflows/handle/stack/SavepointStackImpl.java 79.45% <50.00%> (-0.55%) ⬇️
...flows/handle/stack/savepoints/BuilderSinkImpl.java 80.95% <0.00%> (-1.31%) ⬇️
...dera/node/app/workflows/handle/HandleWorkflow.java 74.30% <61.90%> (-0.61%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 56.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (046ca88) 96732 62934 65.06%
Head commit (0847ded) 96740 (+8) 62936 (+2) 65.06% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16580) 25 14 56.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate correctly the following and preceding chid transactions timestamps
2 participants