refactor: remove State class
#16352
Draft
refactor: remove State class
#16352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Lebedev <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
…cleanup # Conflicts: # platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/State.java
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Node: HAPI Test (Restart) Results7 tests 2 ✅ 3m 37s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 5a59b72. |
Signed-off-by: Nikita Lebedev <[email protected]>
This was referenced Nov 5, 2024
Signed-off-by: Nikita Lebedev <[email protected]>
…n to guarantee that it's always registered. Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
…oolMain. Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
…cleanup # Conflicts: # platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
imalygin
force-pushed
the
15638-merkleroot--merklestateroot--state-cleanup
branch
from
c6bd77c
to
4af0220
Compare
Signed-off-by: Ivan Malygin <[email protected]>
imalygin
force-pushed
the
15638-merkleroot--merklestateroot--state-cleanup
branch
from
7e810c8
to
fa15fb6
Compare
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Ivan Malygin <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
imalygin
reviewed
Nov 15, 2024
| if (trigger == InitTrigger.GENESIS) { | ||
| genesisInit(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void serialize(final SerializableDataOutputStream out) throws IOException { |
There was a problem hiding this comment.
Not sure how important this particular state implementation is, but this serialization/deserialization logic cannot be just removed. However, this class may be no longer relevant, and it doesn't make sense spend too much time fixing it
imalygin
reviewed
Nov 15, 2024
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
Same here. We may want to do here something similar to this commit a53a4a0
…pl`. Added missing registration to PTT. Signed-off-by: Ivan Malygin <[email protected]>
imalygin
force-pushed
the
15638-merkleroot--merklestateroot--state-cleanup
branch
from
f0a97e7
to
6ed59af
Compare
Signed-off-by: Ivan Malygin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces usages of
com.swirlds.platform.state.Statewithcom.swirlds.platform.state.MerkleStateRoot, so that the former can be removed.It also adds initialization code required for
MerkleStateRootto work.For example, the following code initializes the platform state in the instance of
MerkleStateRootfor further use:Fixes #15638