-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 15448: In-memory virtual maps support #15575
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Artem Ananev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15575 +/- ##
=============================================
+ Coverage 63.31% 63.35% +0.03%
- Complexity 20136 20174 +38
=============================================
Files 2531 2536 +5
Lines 94018 94122 +104
Branches 9834 9849 +15
=============================================
+ Hits 59528 59631 +103
+ Misses 30901 30892 -9
- Partials 3589 3599 +10
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
…ests.inMemoryModeSerde() Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
… in VirtualPipeline Signed-off-by: Artem Ananev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the fix looks good. However, I have a very shallow understanding of the implementation details. So it would be good to get another pair of eyes to take a look here.
Just posting a few comments/questions, mostly to clarify things.
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/cache/VirtualNodeCache.java
Show resolved
Hide resolved
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/cache/VirtualNodeCache.java
Show resolved
Hide resolved
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/cache/VirtualNodeCache.java
Outdated
Show resolved
Hide resolved
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/cache/VirtualNodeCache.java
Show resolved
Hide resolved
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/cache/VirtualNodeCache.java
Show resolved
Hide resolved
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
37bff78
Signed-off-by: Artem Ananev <[email protected]>
Fix summary:
Fixes: #15448
Signed-off-by: Artem Ananev [email protected]