-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Disable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #13678
chore: Disable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #13678
Conversation
Signed-off-by: Michael Heinrichs <[email protected]>
Node: Unit Test Results 2 319 files ±0 2 319 suites ±0 2h 29m 21s ⏱️ -9s Results for commit 45a16b2. ± Comparison against base commit 0ac344e. This pull request removes 369 and adds 125 tests. Note that renamed tests count towards both.
This pull request skips 1 test.
|
Node: HAPI Test (Token) Results 20 files 20 suites 5m 35s ⏱️ Results for commit 45a16b2. |
Node: HAPI Test (Node Death Reconnect) Results3 tests 3 ✅ 5m 44s ⏱️ Results for commit 45a16b2. |
Node: HAPI Test (Restart) Results3 tests 3 ✅ 6m 0s ⏱️ Results for commit 45a16b2. |
Node: HAPI Test (Crypto) Results 23 files 23 suites 14m 3s ⏱️ Results for commit 45a16b2. |
Node: HAPI Test (Misc) Results 51 files 51 suites 20m 58s ⏱️ Results for commit 45a16b2. |
Node: HAPI Test (Smart Contract) Results 68 files 68 suites 21m 20s ⏱️ Results for commit 45a16b2. |
Node: HAPI Test (Time Consuming) Results19 tests 19 ✅ 21m 52s ⏱️ Results for commit 45a16b2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @netopyr 🎉
…lerance() (#13678) Signed-off-by: Michael Heinrichs <[email protected]> Signed-off-by: Jeffrey Tang <[email protected]>
Description:
Disables
DeterministicThrottleTest.throttlesWithinPermissibleTolerance()
because it is flaky. The test should be enabled again once it has been redesigned (see #13667).Related issue(s):
Fixes #13666