Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #13678

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Jun 5, 2024

Description:

Disables DeterministicThrottleTest.throttlesWithinPermissibleTolerance() because it is flaky. The test should be enabled again once it has been redesigned (see #13667).

Related issue(s):

Fixes #13666

Signed-off-by: Michael Heinrichs <[email protected]>
@netopyr netopyr added this to the v0.51 milestone Jun 5, 2024
@netopyr netopyr self-assigned this Jun 5, 2024
@netopyr netopyr requested a review from a team June 5, 2024 06:38
@netopyr netopyr requested a review from a team as a code owner June 5, 2024 06:38
Copy link

github-actions bot commented Jun 5, 2024

Node: Unit Test Results

  2 319 files  ±0    2 319 suites  ±0   2h 29m 21s ⏱️ -9s
112 676 tests ±0  112 606 ✅  - 1  70 💤 +1  0 ❌ ±0 
121 187 runs  ±0  121 117 ✅  - 1  70 💤 +1  0 ❌ ±0 

Results for commit 45a16b2. ± Comparison against base commit 0ac344e.

This pull request removes 369 and adds 125 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e3…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
   Address[id=0,nickname=xCkVOjoz,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=3047,hostnameExternal=214.172.184.113,portExternalIpv4=3047,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@4e4c85e1,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@4d2da8e6,memo=ZKAi2LoT],
   Address[id=3,nickname=lJD2bCza,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=13547,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2b0ff367, agrKeyPair=java.security.KeyPair@713932bb, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
   Address[id=0,nickname=gu1okRMt,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=52324,hostnameExternal=143.235.78.61,portExternalIpv4=52324,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@513dc9e2,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@639e05e3,memo=3kpfMSvg],
   Address[id=3,nickname=yjItPH8k,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=61565,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@17cb2dfd, agrKeyPair=java.security.KeyPair@318be20, sigCert=  [0]         Version: 3
         SerialNumber: 12482092706667292405
             IssuerDN: CN=s-aaaa
           Start Date: Sat Jan 01 00:00:00 UTC 2000
           Final Date: Fri Jan 01 00:00:00 UTC 2100
            SubjectDN: CN=s-aaaa
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [3] AddressBook {
   Address[id=0,nickname=R1HYBnMw,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=53186,hostnameExternal=46.159.206.231,portExternalIpv4=53186,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@7dd24a05,agreeCert=<null>,memo=JfiTP2MO],
   Address[id=2,nickname=Bd3O38j7,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=10682,hostnameExternal=25.242.219.209,portExternalIpv4=10682,sigPublicKey=<null>…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@58241679, agrKeyPair=java.security.KeyPair@26a6698a, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=Lhm5h3MM,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=26327,hostnameExternal=76.47.31.67,portExternalIpv4=26327,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@38343728,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@7050e030,memo=0ZGks2DW],
   Address[id=1,nickname=iHR5A18o,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=12918,hostnameExternal=19…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@4003db85, agrKeyPair=java.security.KeyPair@5a140069, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
…
This pull request skips 1 test.
com.hedera.node.app.hapi.utils.throttles.DeterministicThrottleTest ‑ throttlesWithinPermissibleTolerance()

Copy link

github-actions bot commented Jun 5, 2024

Node: HAPI Test (Token) Results

 20 files   20 suites   5m 35s ⏱️
257 tests 257 ✅ 0 💤 0 ❌
260 runs  260 ✅ 0 💤 0 ❌

Results for commit 45a16b2.

Copy link

github-actions bot commented Jun 5, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 44s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 45a16b2.

Copy link

github-actions bot commented Jun 5, 2024

Node: HAPI Test (Restart) Results

3 tests   3 ✅  6m 0s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 45a16b2.

Copy link

github-actions bot commented Jun 5, 2024

Node: HAPI Test (Crypto) Results

 23 files   23 suites   14m 3s ⏱️
350 tests 350 ✅ 0 💤 0 ❌
356 runs  356 ✅ 0 💤 0 ❌

Results for commit 45a16b2.

Copy link

github-actions bot commented Jun 5, 2024

Node: HAPI Test (Misc) Results

 51 files   51 suites   20m 58s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
374 runs  374 ✅ 0 💤 0 ❌

Results for commit 45a16b2.

Copy link

github-actions bot commented Jun 5, 2024

Node: HAPI Test (Smart Contract) Results

 68 files   68 suites   21m 20s ⏱️
609 tests 609 ✅ 0 💤 0 ❌
637 runs  637 ✅ 0 💤 0 ❌

Results for commit 45a16b2.

Copy link

github-actions bot commented Jun 5, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  21m 52s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 45a16b2.

Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @netopyr 🎉

@netopyr netopyr modified the milestones: v0.51, v0.52 Jun 5, 2024
@jeromy-cannon jeromy-cannon merged commit 07d0a61 into develop Jun 5, 2024
64 checks passed
@jeromy-cannon jeromy-cannon deleted the 13666-disable-deterministic-throttle-test branch June 5, 2024 09:13
JeffreyDallas pushed a commit that referenced this pull request Jun 6, 2024
…lerance() (#13678)

Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable DeterministicThrottleTest.throttlesWithinPermissibleTolerance()
3 participants