Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #13667

Open
netopyr opened this issue Jun 4, 2024 · 0 comments · May be fixed by #17412
Open

Stabilize DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #13667

netopyr opened this issue Jun 4, 2024 · 0 comments · May be fixed by #17412
Assignees
@MiroslavGatsanoga
Labels
HapiThursday

Comments

@netopyr
Copy link
Contributor

netopyr commented Jun 4, 2024 •
edited
Loading

The test DeterministicThrottleTest.throttlesWithinPermissibleTolerance() is flaky, and we disabled it in #13666 .

The reason is probably that it uses System.nanoTime(). We should redesign the test (and maybe also DeterministicThrottle) so that we can control time and get deterministic results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiroslavGatsanoga MiroslavGatsanoga

Labels
HapiThursday
Projects
Services Team
Status: 👷🏼‍♀️ In Progress
Milestone
No milestone
2 participants
@netopyr @MiroslavGatsanoga