Skip to content

Commit

Permalink
Remove validation of ledger state at startup (#8290)
Browse files Browse the repository at this point in the history 
Signed-off-by: Richard Bair <[email protected]>
  • Loading branch information
@rbair23
rbair23 authored Aug 31, 2023
1 parent b3328e2 commit 4eca8ff
Showing 1 changed file with 3 additions and 95 deletions.
98 changes: 3 additions & 95 deletions hedera-node/hedera-app/src/main/java/com/hedera/node/app/Hedera.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,6 @@ private void onStateInitialized(
// Since we now have an "app" instance, we can update the dual state accessor. This is *ONLY* used by the app to
// produce a log summary after a freeze. We should refactor to not have a global reference to this.
updateDualState(dualState);

logger.info("Validating ledger state...");
validateLedgerState(state);
logger.info("Ledger state ok");
}

/**
Expand Down Expand Up @@ -506,27 +502,6 @@ private boolean sha384DigestIsAvailable(@NonNull final NamedDigestFactory digest
}
}

/** Verifies some aspects of the ledger state */
@SuppressWarnings("java:S1181") // catching Throwable instead of Exception when we do a direct System.exit()
private void validateLedgerState(@NonNull final HederaState state) {
// For a non-zero stake node, validates presence of a self-account in the address book.
final var selfNodeInfo = daggerApp.networkInfo().selfNodeInfo();
if (!selfNodeInfo.zeroStake() && selfNodeInfo.accountId() == null) {
logger.fatal("Node is not zero-stake, but has no known account");
daggerApp.systemExits().fail(1);
}

// Verify the ledger state. At the moment, this is a sanity check that we still have all HBARs present and
// accounted for. We may do more checks in the future. Every check we add slows down restart, especially when
// we start loading massive amounts of state from disk.
try {
daggerApp.ledgerValidator().validate(state);
} catch (Throwable th) {
logger.fatal("Ledger validation failed", th);
daggerApp.systemExits().fail(1);
}
}

/*==================================================================================================================
*
* Other app lifecycle methods
Expand Down Expand Up @@ -590,7 +565,6 @@ private void onPreHandle(@NonNull final Event event, @NonNull final HederaState
private void onHandleConsensusRound(
@NonNull final Round round, @NonNull final SwirldDualState dualState, @NonNull final HederaState state) {
daggerApp.workingStateAccessor().setHederaState(state);
// TBD: Add in dual state when needed :: daggerApp.dualStateAccessor().setDualState(dualState);
daggerApp.handleWorkflow().handleRound(state, round);
}

Expand Down Expand Up @@ -645,7 +619,7 @@ private void genesis(@NonNull final MerkleHederaState state, @NonNull final Swir

// And now that the entire dependency graph has been initialized, and we have config, and all migration has
// been completed, we are prepared to initialize in-memory data structures. These specifically are loaded
// from information held in state.
// from information held in state (especially those in special files).
initializeFeeManager(state);
initializeExchangeRateManager(state);
initializeThrottleManager(state);
Expand All @@ -666,46 +640,8 @@ private void genesis(@NonNull final MerkleHederaState state, @NonNull final Swir
// networkCtx.markPostUpgradeScanStatus();
}

// TODO SHOULD BE USED FOR ALL START/RESTART/GENESIS SCENARIOS
private void stateInitializationFlow() {
/*
final var lastThrottleExempt = bootstrapProperties.getLongProperty(ACCOUNTS_LAST_THROTTLE_EXEMPT);
// The last throttle-exempt account is configurable to make it easy to start dev networks
// without throttling
numberConfigurer.configureNumbers(hederaNums, lastThrottleExempt);
workingState.updateFrom(activeState);
log.info("Context updated with working state");
final var activeHash = activeState.runningHashLeaf().getRunningHash().getHash();
recordStreamManager.setInitialHash(activeHash);
log.info("Record running hash initialized");
if (hfs.numRegisteredInterceptors() == 0) {
fileUpdateInterceptors.forEach(hfs::register);
log.info("Registered {} file update interceptors", fileUpdateInterceptors.size());
}
*/
}

// TODO SHOULD BE USED FOR ALL START/RESTART/GENESIS SCENARIOS
private void storeFlow() {
/*
backingTokenRels.rebuildFromSources();
backingAccounts.rebuildFromSources();
backingTokens.rebuildFromSources();
backingNfts.rebuildFromSources();
log.info("Backing stores rebuilt");
usageLimits.resetNumContracts();
aliasManager.rebuildAliasesMap(workingState.accounts(), (num, account) -> {
if (account.isSmartContract()) {
usageLimits.recordContracts(1);
}
});
log.info("Account aliases map rebuilt");
*/
}
// The last throttle-exempt account is configurable to make it easy to start dev networks
// without throttling

// TODO SHOULD BE USED FOR ALL START/RESTART/GENESIS SCENARIOS
private void entitiesFlow() {
Expand All @@ -717,34 +653,6 @@ private void entitiesFlow() {
sigImpactHistorian.invalidateCurrentWindow();
log.info("Signature impact history invalidated");
// Re-initialize the "observable" system files; that is, the files which have
// associated callbacks managed by the SysFilesCallback object. We explicitly
// re-mark the files are not loaded here, in case this is a reconnect.
networkCtxManager.setObservableFilesNotLoaded();
networkCtxManager.loadObservableSysFilesIfNeeded();
*/
}

// Only called during genesis
private void createAddressBookIfMissing() {
// Get the address book from the platform and create a NodeAddressBook, and write the protobuf bytes of
// this into state. (This should be done by the File service schema. Or somebody who owns it.) To do that,
// we need to make the address book available in the SPI so the file service can get it. Or, is it owned
// by the network admin service, and the current storage is in the file service, but doesn't actually belong
// there. I tend to think that is the case. But we use the file service today and a special file and that is
// actually depended on by the mirror node. So to change that would require a HIP.
/*
writeFromBookIfMissing(fileNumbers.addressBook(), this::platformAddressBookToGrpc);
*/
}

// Only called during genesis
private void createNodeDetailsIfMissing() {
// Crazy! Same contents as the address book, but this one is "node details" file. Two files with the same
// contents? Why?
/*
writeFromBookIfMissing(fileNumbers.nodeDetails(), this::platformAddressBookToGrpc);
*/
}

Expand Down

0 comments on commit 4eca8ff

Please sign in to comment.