Add schema registry and migrator components #9710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
…try-component Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
steven-sheehy
changed the title
steven-sheehy
requested changes
Nov 5, 2024
...-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/ServicesRegistryImpl.java
Outdated
Show resolved
Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java
Outdated
Show resolved
Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java
Show resolved
Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java
Show resolved
Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java
Show resolved
Hide resolved
...a-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/ServiceMigratorImpl.java
Show resolved
Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java
Show resolved
Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java
Show resolved
Hide resolved
…ation Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
commented
Nov 6, 2024
| @@ -50,7 +50,7 @@ public SelfNodeInfo selfNodeInfo() { | |||
| @Nonnull | |||
| @Override | |||
| public List<NodeInfo> addressBook() { | |||
| throw new UnsupportedOperationException("Address book is not supported."); | |||
| return List.of(mockSelfNodeInfo()); | |||
There was a problem hiding this comment.
This method will be used when we build the state. That is why this change is in the PR
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
bilyana-gospodinova
force-pushed
the
09259-state-implementation
branch
from
b59a4ff
to
cd96150
Compare
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
…try-component Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
bilyana-gospodinova
force-pushed
the
09259-state-implementation
branch
from
f3d60cf
to
fa57b07
Compare
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
…try-component Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9710 +/- ##
============================================
- Coverage 92.35% 92.27% -0.09%
- Complexity 7635 7766 +131
============================================
Files 927 948 +21
Lines 32085 32437 +352
Branches 4083 4113 +30
============================================
+ Hits 29632 29930 +298
- Misses 1496 1543 +47
- Partials 957 964 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds subcomponents needed for reusable services -
ServicesRegistryImpl, SchemaRegistryImpl and ServiceMigratorImpl components
This PR adds:
ServicesRegistryImpl class similar to FakeServicesRegistry in services + unit tests
SchemaRegistryImpl class similar to FakeSchemaRegistry in services + unit tests
ServiceMigratorImpl class similar to FakeServiceMigrator in services + unit tests
Related issue(s):
Fixes #9260
Notes for reviewer:
Checklist