fix: masks ip address in request details passed as argument to MN client

[konstantinabl]

Description:

The issue arises from the fact requestDetails are passed as an argument to the repeatedRequest method in MN client, because they are needed for the next method call

public async repeatedRequest(methodName: string, args: any[], repeatCount: number, requestDetails?: RequestDetails) {
    let result;
    for (let i = 0; i < repeatCount; i++) {
      try {
        result = await this[methodName](...args);
      } catch (e: any) {
      .......

However, further down in the method the args are logged.

Related issue(s):

Fixes #3266

[github-actions]

Test Results

 21 files   - 1  281 suites   - 10   35m 1s ⏱️ -41s
609 tests ±0  603 ✅ + 1  4 💤 ±0  2 ❌  - 1 
705 runs   - 3  697 ✅  -  2  4 💤 ±0  4 ❌  - 1 

For more details on these failures, see this check.

Results for commit 7e24f26. ± Comparison against base commit b99655e.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.

"before all" hook in "@api-batch-2 RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before all" hook in "@api-batch-2 RPC Server Acceptance Tests"

"before all" hook for "should associate to a token" ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests "before all" hook for "should associate to a token"

♻️ This comment has been updated with latest results.

[Nana-EC]

Just checking is this the only place to remove it?
Other approach is to set IP undefined after it's utilized in the rate limiter if possible.

[konstantinabl]

No, its not the only place, i think there is one more, working on it
I will check your suggestion as well

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (b99655e) to head (7e24f26).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
+ Coverage   76.64%   77.89%   +1.25%     
==========================================
  Files          65       66       +1     
  Lines        4449     4470      +21     
  Branches     1014     1003      -11     
==========================================
+ Hits         3410     3482      +72     
+ Misses        672      613      -59     
- Partials      367      375       +8     

Flag	Coverage Δ
config-service	98.14% <ø> (ø)
relay	78.64% <100.00%> (+0.06%)	⬆️
server	83.28% <ø> (?)
ws-server	36.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts	86.19% <100.00%> (-1.54%)	⬇️
packages/relay/src/lib/eth.ts	71.07% <100.00%> (-3.55%)	⬇️

... and 29 files with indirect coverage changes

[quiet-node]

LGTM! Thanks for the quick great work!

[Nana-EC]

Looking good but I won't if there is a single location we can set this oce

[Nana-EC]

This works but is there a place where we can do this once before it's passed into the eth.ts but after it's utilized locally?