Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added gas deviation to the release-light tests. #3264

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

ebadiere
Copy link
Contributor

@ebadiere ebadiere commented Nov 14, 2024

This PR adds a gas deviation to the gas price in the @release-light tests, and removes some warnings in the IDE.

Related issue(s):

Fixes #3259

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ebadiere ebadiere requested review from AlfredoG87, Nana-EC and a team as code owners November 14, 2024 20:57
@ebadiere ebadiere self-assigned this Nov 14, 2024
@ebadiere ebadiere added the bug Something isn't working label Nov 14, 2024
@ebadiere ebadiere added this to the 0.61.0 milestone Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

Test Results

 19 files   -  1  248 suites   - 9   31m 31s ⏱️ - 1m 52s
609 tests ± 0  604 ✅ + 2  4 💤 ±0  1 ❌  - 2 
692 runs   - 12  686 ✅  - 10  5 💤 ±0  1 ❌  - 2 

For more details on these failures, see this check.

Results for commit 54ad715. ± Comparison against base commit d1a8fbc.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
"before all" hook for "should associate to a token" ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests "before all" hook for "should associate to a token"
should eventually exhaust the hbar limit for a BASIC user after multiple deployments of large contracts, and not throw an error ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests @hbarlimiter-batch3 Unlimited should eventually exhaust the hbar limit for a BASIC user after multiple deployments of large contracts, and not throw an error

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvement suggestions.
Also please update the description, there's some changes that does seem related and might relate to other issues that need to be highlighted.

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nana-EC Nana-EC merged commit 27a10dc into main Nov 15, 2024
44 of 46 checks passed
@Nana-EC Nana-EC deleted the 3259-release-light branch November 15, 2024 15:57
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.00%. Comparing base (3bd07ef) to head (54ad715).
Report is 17 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3bd07ef) and HEAD (54ad715). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3bd07ef) HEAD (54ad715)
relay 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3264      +/-   ##
==========================================
- Coverage   83.17%   75.00%   -8.18%     
==========================================
  Files          66       22      -44     
  Lines        4314      916    -3398     
  Branches      843      172     -671     
==========================================
- Hits         3588      687    -2901     
+ Misses        483      191     -292     
+ Partials      243       38     -205     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay ?
server 83.28% <ø> (-0.25%) ⬇️
ws-server 36.66% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The release-light test suite needs to account for gas deviation.
3 participants