Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade node version to 20. (#3245) #3247

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: Upgrade node version to 20. (#3245) #3247

merged 1 commit into from
Nov 11, 2024

Conversation

ebadiere
Copy link
Contributor

Updated some GH workflows to use node version 20. Cherry-pick commit to test alpha on previewnet.

  • chore: Upgrade node version to 20.

  • chore: Updated references to node 20.

Fixes #3156

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ebadiere
chore: Upgrade node version to 20. (#3245)
fc5bd8b 
* chore: Upgrade node version to 20.

Signed-off-by: Eric Badiere <[email protected]>

* chore: Updated references to node 20.

Signed-off-by: Eric Badiere <[email protected]>

---------

Signed-off-by: Eric Badiere <[email protected]>
@ebadiere ebadiere added the dependencies Pull requests that update a dependency file label Nov 11, 2024
@ebadiere ebadiere added this to the 0.60.0 milestone Nov 11, 2024
@ebadiere ebadiere self-assigned this Nov 11, 2024
@ebadiere ebadiere requested review from AlfredoG87, Nana-EC and a team as code owners November 11, 2024 20:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@quiet-node quiet-node modified the milestones: 0.60.0, 0.59.0 Nov 11, 2024
@quiet-node quiet-node added process Build, test and deployment-process related tasks and removed dependencies Pull requests that update a dependency file labels Nov 11, 2024
acuarica
acuarica approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Test Results

    4 files   -  19    420 suites  +139   19s ⏱️ - 37m 28s
1 486 tests +879  1 485 ✅ +890  1 💤  - 3  0 ❌  - 8 
1 495 runs  +786  1 494 ✅ +797  1 💤  - 3  0 ❌  - 8 

Results for commit fc5bd8b. ± Comparison against base commit 9d4fab7.

♻️ This comment has been updated with latest results.

@ebadiere ebadiere merged commit a4099b4 into release/0.59 Nov 11, 2024
47 of 50 checks passed
@ebadiere ebadiere deleted the 3156-cherry-pick-node-version-20 branch November 11, 2024 20:37
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (9d4fab7) to head (fc5bd8b).
Report is 1 commits behind head on release/0.59.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release/0.59    #3247   +/-   ##
=============================================
  Coverage         83.12%   83.12%           
=============================================
  Files                66       66           
  Lines              4314     4314           
  Branches            843      843           
=============================================
  Hits               3586     3586           
  Misses              485      485           
  Partials            243      243
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 85.23% <ø> (ø)
server 83.52% <ø> (ø)
ws-server 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiet-node quiet-node quiet-node approved these changes

@acuarica acuarica acuarica approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87 AlfredoG87 is a code owner

@Nana-EC Nana-EC Awaiting requested review from Nana-EC Nana-EC is a code owner

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas JeffreyDallas is a code owner automatically assigned from hashgraph/release-engineering

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@ebadiere ebadiere

Labels
process Build, test and deployment-process related tasks
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.59.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ebadiere @acuarica @quiet-node