fix: A series of small changes to stabilize tests #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nection handling to address flaky tests. Signed-off-by: Eric Badiere <[email protected]>
ebadiere
requested review from
AlfredoG87,
georgi-l95,
Ivo-Yankov,
a team and
Nana-EC
as code owners
Test Results 23 files + 22 338 suites +329 1h 27m 25s ⏱️ + 1h 26m 48s For more details on these failures, see this check. Results for commit 8a9d0c4. ± Comparison against base commit 3bd07ef. ♻️ This comment has been updated with latest results. |
tests running against servers running locally. Signed-off-by: Eric Badiere <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3242 +/- ##
==========================================
- Coverage 83.17% 77.85% -5.32%
==========================================
Files 66 66
Lines 4314 4453 +139
Branches 843 993 +150
==========================================
- Hits 3588 3467 -121
- Misses 483 613 +130
- Partials 243 373 +130
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the checking of connection as part of a connection handling process for the
afterEachhook in the tests. It also removes aUtils.waitby resolving a promise before continuing, and adds some gas deviation.Related issue(s):
Fixes #3204