fix WS_NEW_HEADS_ENABLED default

[treethought]

Description:
Restores the behavior of defaulting to true for the env var.

Fixes #3227

This change was originally made in #2361, but seems to have been lost in #3047 (more specific at this line)

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[quiet-node]

Hello @treethought, thank you very much for your contribution! Great catch!! However, could you please create a GitHub issue detailing the problem and the intended purpose of this fix? Additionally, kindly link the issue to this PR.

For guidance on structuring your contribution to align with our standards, please refer to this document.

[quiet-node]

LGTM! TYVM for the great catch!

[quiet-node]

@natanasow Hey Nikki could you please double check to make sure that the loss at at this line wasn't on purpose?

[natanasow]

@natanasow Hey Nikki could you please double check to make sure that the loss at at this line wasn't on purpose?

@quiet-node It wasn't on purpose and most likely happened during resolving conflicts.

@treethought There is another approach I would choose for that issue. The new config service supports default values so we can add it here https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/packages/config-service/src/services/globalConfig.ts#L713

[victor-yanev]

@treethought There is another approach I would choose for that issue. The new config service supports default values so we can add it here https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/packages/config-service/src/services/globalConfig.ts#L713

+1, it would be better for default values to be defined inside globalConfig.ts

[quiet-node]

LGTM! Thanks for the contribution!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (4f0b2ea) to head (d2f61ea).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3226   +/-   ##
=======================================
  Coverage   83.17%   83.17%           
=======================================
  Files          66       66           
  Lines        4314     4314           
  Branches      843      843           
=======================================
  Hits         3588     3588           
  Misses        483      483           
  Partials      243      243           

Flag	Coverage Δ
config-service	98.14% <ø> (ø)
relay	85.29% <ø> (ø)
server	83.52% <ø> (ø)
ws-server	36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ckages/config-service/src/services/globalConfig.ts	100.00% <ø> (ø)

[natanasow]

LGTM.

[quiet-node]

@treethought Looks like your commit wasn't signed by your GPG key. Here’s a helpful resource: Signing Commits.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[treethought]

@treethought Looks like your commit wasn't signed by your GPG key. Here’s a helpful resource: Signing Commits.

pushed with signed commit

[ebadiere]

LG

[quiet-node]

@treethought merged the commit! 🚀🚀🚀 Thank you very much for the work! Look forward to more contributions in the future! 🙌🏼🙌🏼🙌🏼