fix: 3198 cherry pick npm package version #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Capture the npm_package_version Signed-off-by: ebadiere <[email protected]> * fix: Adding npm_package_version at the root package.json file to allow test framework to load the value in the config service. Also some clean up. Signed-off-by: ebadiere <[email protected]> * chore: Updated package-lock.json Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]>
package.json and rebuilt the package-lock.json. Signed-off-by: ebadiere <[email protected]>
|
ebadiere
changed the title
quiet-node
approved these changes
Oct 31, 2024
Test Results 22 files ± 0 291 suites - 18 33m 5s ⏱️ -57s For more details on these failures, see this check. Results for commit 3f8a242. ± Comparison against base commit 97017ac. ♻️ This comment has been updated with latest results. |
Nana-EC
reviewed
Oct 31, 2024
Nana-EC
approved these changes
Oct 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.59 #3200 +/- ##
=============================================
Coverage 83.39% 83.39%
=============================================
Files 66 66
Lines 4283 4283
Branches 835 835
=============================================
Hits 3572 3572
Misses 471 471
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry-picked fix for the
web3_clientVersionmethod.The ConfigService was using an all caps version of the npm_package_version of the env var definition but in a node context the env var is lowercase: npm_package_version. Nothing was being returned from the web3_clientVersion method.
Related issue(s):
Fixes #3198
Notes for reviewer:
Simply changing the case of the env var definition in the GlobalConfig.ts class prevents updating conditional logic that already works. Adding the version number to the root package.json file allows it to be loaded by the ConfigService.ts which loads before the acceptance tests framework.
Checklist