Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skipped title check CI job for forked PRs #3196

Conversation

quiet-node
Copy link
Member

Description:
Title check CI job fail for PRs that are from a forked repository due to the lack of the secret.GITHUB_TOKEN. This PR adds an option to skip the check if the PRs are from forked repos.

Related issue(s):

Fixes #3195

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the Internal For changes that affect the project's internal workings but not its outward-facing functionality. label Oct 31, 2024
@quiet-node quiet-node added this to the 0.60.0 milestone Oct 31, 2024
@quiet-node quiet-node self-assigned this Oct 31, 2024
Copy link

sonarcloud bot commented Oct 31, 2024

Copy link

github-actions bot commented Oct 31, 2024

Test Results

 24 files   -   1  279 suites   - 57   37m 41s ⏱️ - 1m 4s
606 tests  -   1  596 ✅ +  4  4 💤 ±0  6 ❌  - 5 
646 runs   - 212  633 ✅  - 202  4 💤  - 3  9 ❌  - 7 

For more details on these failures, see this check.

Results for commit 010462e. ± Comparison against base commit d6fece1.

This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.
"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"
"before each" hook for "should execute "eth_getStorageAt" request to get old state with passing specific block" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get old state with passing specific block"
"before each" hook for "should verify the estimated and actual transaction fees for file transactions are approximately equal" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests "before each" hook for "should verify the estimated and actual transaction fees for file transactions are approximately equal"
"before all" hook in "@precompile-calls Tests for eth_call with HTS" ‑ RPC Server Acceptance Tests Acceptance tests @precompile-calls Tests for eth_call with HTS "before all" hook in "@precompile-calls Tests for eth_call with HTS"
"before all" hook in "RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Acceptance Tests "before all" hook in "RPC Server Acceptance Tests"

♻️ This comment has been updated with latest results.

Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@quiet-node quiet-node merged commit 976866b into main Oct 31, 2024
46 of 48 checks passed
@quiet-node quiet-node deleted the 3195-update-the-github-workflow-to-allow-skipping-the-title-check-job-for-forked-prs branch October 31, 2024 15:03
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.39%. Comparing base (d6fece1) to head (010462e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3196   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files          66       66           
  Lines        4283     4283           
  Branches      835      835           
=======================================
  Hits         3572     3572           
  Misses        471      471           
  Partials      240      240           
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 85.60% <ø> (ø)
server 83.52% <ø> (ø)
ws-server 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the GitHub workflow to allow skipping the title check job for forked PRs
4 participants