Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added e2e tests for multiple users across various tiers #3190

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Oct 31, 2024

Description:
This PR adds e2e tests for multiple users across various tiers

Related issue(s):

Fixes #3068

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the Internal For changes that affect the project's internal workings but not its outward-facing functionality. label Oct 31, 2024
@quiet-node quiet-node added this to the 0.60.0 milestone Oct 31, 2024
@quiet-node quiet-node self-assigned this Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

Test Results

 21 files  + 3  281 suites  +28   34m 42s ⏱️ + 5m 16s
609 tests + 6  602 ✅ + 5  4 💤 ±0  3 ❌ +1 
714 runs   - 18  706 ✅  - 20  4 💤 ±0  4 ❌ +2 

For more details on these failures, see this check.

Results for commit 7ae7165. ± Comparison against base commit 0e31b34.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 3068-v2-hbar-rate-limit-redesign-create-e2e-tests-for-multiple-usrs-with-different-spending-plans branch from a409ddb to 5cf6d5c Compare November 1, 2024 15:39
@quiet-node quiet-node marked this pull request as ready for review November 1, 2024 15:39
@quiet-node quiet-node force-pushed the 3068-v2-hbar-rate-limit-redesign-create-e2e-tests-for-multiple-usrs-with-different-spending-plans branch from 5cf6d5c to 1b544d8 Compare November 4, 2024 18:09
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick question around the Utils.wait.

Signed-off-by: Logan Nguyen <[email protected]>
ebadiere
ebadiere previously approved these changes Nov 5, 2024
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Signed-off-by: Logan Nguyen <[email protected]>
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@quiet-node quiet-node merged commit acc4538 into main Nov 6, 2024
43 of 45 checks passed
@quiet-node quiet-node deleted the 3068-v2-hbar-rate-limit-redesign-create-e2e-tests-for-multiple-usrs-with-different-spending-plans branch November 6, 2024 22:36
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (0e31b34) to head (7ae7165).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3190   +/-   ##
=======================================
  Coverage   83.16%   83.17%           
=======================================
  Files          66       66           
  Lines        4312     4314    +2     
  Branches      843      843           
=======================================
+ Hits         3586     3588    +2     
  Misses        483      483           
  Partials      243      243           
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 85.29% <ø> (+<0.01%) ⬆️
server 83.52% <ø> (ø)
ws-server 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HBAR Rate Limit Redesign] Create e2e tests for multiple users with different spending plans
4 participants