Smart Contracts hbar Allowance and Approval #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lukelee-sl <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Assign number to hip Signed-off-by: Michael Garber <[email protected]>
Nana-EC
requested changes
Mar 8, 2024
Signed-off-by: lukelee-sl <[email protected]>
|
We believe that the functionality introduced in this HIP is valuable. However, it does not address the specific issue we outlined in detail here. We require the capability for a contract to spend users' HBAR if it has received explicit spending approval. |
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
|
Hey team! This particular issue would provide a lot of value to our launchpad. The current bug introduced by the allowance mechanisms prevents us from being able to send any NFT that includes a fallback fee. This is a significant blocker for smart contracts. |
… a section discussing notification of update events Signed-off-by: lukelee-sl <[email protected]>
HIP/hip-906.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Once the above functionality has been implemented in services, an EOA or contract with hbars will be able to call the `hbarAllownace` and `hbarApprove` functions as follows: |
There was a problem hiding this comment.
hbarAllownace -> hbarAllowance
HIP/hip-906.md
Outdated
|
|
||
| ## Key Benefits and Possible Use Cases | ||
| Key benefits include: | ||
| 1. Better developer experience. Develops will not have to use the SDK to perform tasks that will be available via this HIP. |
There was a problem hiding this comment.
Develops -> Developers ?
HIP/hip-906.md
Outdated
| ## Updates via HAPI | ||
|
|
||
| It is possible that the approved allowances for a spender can be spent or increased by submitting a separate approval transaction via | ||
| HAPI. In this case, the smart contract would not be aware of these changes in state could possibly hold stale state. While it would be possible |
There was a problem hiding this comment.
This sentence is not fully clear. Probably you meant:
would not be aware of these changes in state and it could possibly hold stale state?
Signed-off-by: lukelee-sl <[email protected]>
Nana-EC
previously approved these changes
Apr 17, 2024
Signed-off-by: Michael Garber <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
mgarbs
approved these changes
Apr 22, 2024
kimbor
pushed a commit
to kimbor/hedera-improvement-proposal
that referenced
this pull request
Jun 24, 2024
Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: Michael Garber <[email protected]> Co-authored-by: Michael Garber <[email protected]> Signed-off-by: Kim Rader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This HIP describes a proposal to enable hbar allowance and approvals from smart contracts. This will allow developers to grant allowances from an EOA or a contract from within smart contracts code rather than having to resort to using HAPI for this functionality
Checklist